Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## latest #3200 +/- ##
==========================================
- Coverage 72.92% 72.72% -0.21%
==========================================
Files 436 442 +6
Lines 106033 106631 +598
Branches 17071 17173 +102
==========================================
+ Hits 77327 77544 +217
- Misses 28430 28810 +380
- Partials 276 277 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jajhall
left a comment
There was a problem hiding this comment.
I trust you on the technical changes, but in the documentation there are typos in parallel.md since it compiles to give
Setting hipo\_parallel_force (resp. hipo\_parallel\_forbid) to one of these values, or a sum of values, forces (resp. forbids) the use of parallelism in the corresponding phases. These options override any other behaviour enforced by other options. If a given phase is both forced and forbidden, the default behaviour is used instead. For instance, setting hipo\_parallel\_force to 81 = 1+16+64 and hipo\_parallel\_forbid to 68 = 4+64 forces the use of parallelism in the analyse phase and for building the normal equations values, and forbids it for the reordering of augmented system.
Also, could you comment on the default value of hipo_parallel_type, hipo_parallel_force and hipo_parallel_forbid, as well as adding a health warning about changing hipo_parallel_force or hipo_parallel_forbid: something along the lines of "the heuristics are very much likely to be correct, but force/forbid are ways of overriding them"
hipo_parallel_forceandhipo_parallel_forbid, to force or forbid the use of specific parallel techniques. They are both bit maps and their details are explained in the documentation.