Parallel redesign - #3192
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## latest #3192 +/- ##
==========================================
+ Coverage 73.06% 73.12% +0.06%
==========================================
Files 445 445
Lines 107661 107801 +140
Branches 17257 17262 +5
==========================================
+ Hits 78659 78826 +167
+ Misses 28726 28699 -27
Partials 276 276 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fwesselm
reviewed
Aug 20, 2026
fwesselm
left a comment
Collaborator
There was a problem hiding this comment.
@Opt-Mucca, this looks great! Just a couple of uninformed comments from me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a first redesign of the parallel MIP code. I'm just going to dot point the major changes:
preparedNodesof each worker. A worker now only processes nodes assigned to it.backtrackPlungeto a simple DFS style algorithm without the ability to skip a level of the tree while backtracking based on pseudocosts.nodequeueattached to each worker to a simplestd::vector.For my tests on 8 threads this gives a 6.5% time improvement and 6% LP iteration improvement. It gives a 1% performance degradation on single-threaded performance. Edit: This change should also use 40% less memory.
Reason for single-threaded degradation: There is one outlier instance
tbfp-networkwhere the sub-mip no longer finds the optimal solution instantly. This means the problems solves 5x slower. It stems from thebacktrackPlungechanges, but I'd mostly chalk it up to randomness. Without this instance the change is performance neutral on single-threaded and more than 6.5% improving on 8 threads.