Skip to content

Fix 3166 - #3182

Merged
Opt-Mucca merged 4 commits into
latestfrom
fix-3166
Aug 24, 2026
Merged

Fix 3166#3182
Opt-Mucca merged 4 commits into
latestfrom
fix-3166

Conversation

@Opt-Mucca

Copy link
Copy Markdown
Collaborator

This fixes #3166

I believe the error was that some data structures were not being updated when pruning in partitionRefinement. This had absolutely no effect on my run of MIPLIB 2017 with a 30min time limit. Given I'm not that comfortable with the symmetry code still, it should probably wait for a review.

@Opt-Mucca
Opt-Mucca requested a review from fwesselm July 28, 2026 10:16
@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.22%. Comparing base (1945ea8) to head (819a538).
⚠️ Report is 1 commits behind head on latest.

Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #3182      +/-   ##
==========================================
+ Coverage   73.17%   73.22%   +0.04%     
==========================================
  Files         445      445              
  Lines      107802   107826      +24     
  Branches    17258    17262       +4     
==========================================
+ Hits        78887    78951      +64     
+ Misses      28639    28599      -40     
  Partials      276      276              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fwesselm fwesselm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Opt-Mucca, I am still learning about the symmetry detection code, but this looks correct!

I added a test, I hope that's OK, your code changes are now covered.

@Opt-Mucca

Copy link
Copy Markdown
Collaborator Author

@fwesselm I'm still learning it too. Will merge this when the tests pass!

@Opt-Mucca
Opt-Mucca merged commit f614a82 into latest Aug 24, 2026
536 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants