Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## latest #3182 +/- ##
==========================================
+ Coverage 73.17% 73.22% +0.04%
==========================================
Files 445 445
Lines 107802 107826 +24
Branches 17258 17262 +4
==========================================
+ Hits 78887 78951 +64
+ Misses 28639 28599 -40
Partials 276 276 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fwesselm
approved these changes
Aug 24, 2026
Collaborator
There was a problem hiding this comment.
@Opt-Mucca, I am still learning about the symmetry detection code, but this looks correct!
I added a test, I hope that's OK, your code changes are now covered.
Collaborator
Author
|
@fwesselm I'm still learning it too. Will merge this when the tests pass! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #3166
I believe the error was that some data structures were not being updated when pruning in
partitionRefinement. This had absolutely no effect on my run of MIPLIB 2017 with a 30min time limit. Given I'm not that comfortable with the symmetry code still, it should probably wait for a review.