Skip to content

Remove assert for empty workers - #3134

Closed
Opt-Mucca wants to merge 1 commit into
latestfrom
fix-julia-pipeline
Closed

Remove assert for empty workers#3134
Opt-Mucca wants to merge 1 commit into
latestfrom
fix-julia-pipeline

Conversation

@Opt-Mucca

Copy link
Copy Markdown
Collaborator

No description provided.

@Opt-Mucca
Opt-Mucca requested a review from odow July 6, 2026 08:55
@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.16%. Comparing base (8e8d4f6) to head (422df29).
⚠️ Report is 1 commits behind head on latest.

Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #3134      +/-   ##
==========================================
- Coverage   73.16%   73.16%   -0.01%     
==========================================
  Files         430      430              
  Lines      103967   103965       -2     
  Branches    16718    16717       -1     
==========================================
- Hits        76069    76065       -4     
- Misses      27622    27624       +2     
  Partials      276      276              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@odow odow left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t have the ability to review this. As a high level comment: tests, or it didn’t happen. I would love to better understand how we can more robustly test highs, instead of running a few large scale instances and declaring success.

@Opt-Mucca Opt-Mucca closed this Jul 6, 2026
@jajhall

jajhall commented Jul 6, 2026

Copy link
Copy Markdown
Member

I don’t have the ability to review this. As a high level comment: tests, or it didn’t happen. I would love to better understand how we can more robustly test highs, instead of running a few large scale instances and declaring success.

Although the need to test HiGHS more thoroughly on LPs, and to test presolve rules on curated special cases has been exposed in recent weeks - and is being addressed, the testing of HiGHS has always been rather more than "running a few large scale instances and declaring success." @fwesselm is performing regression testing on about 850 MIPs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants