Skip to content

fix: wrong comment in postsolve basis - #3119

Merged
jajhall merged 1 commit into
ERGO-Code:latestfrom
Wronskode:fix/wrong_comment_postsolve
Jul 1, 2026
Merged

fix: wrong comment in postsolve basis#3119
jajhall merged 1 commit into
ERGO-Code:latestfrom
Wronskode:fix/wrong_comment_postsolve

Conversation

@Wronskode

Copy link
Copy Markdown
Contributor

The comments in the case HighsBasisStatus::kUpper branch of
HighsPostsolveStack::SingletonRow::undo incorrectly referred to a
"tightened lower bound" and swapped the row bound origin, even though
this branch only handles the case where the column's upper bound was
tightened.

@jajhall jajhall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jajhall
jajhall merged commit c90da40 into ERGO-Code:latest Jul 1, 2026
326 checks passed
@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.17%. Comparing base (ff64efa) to head (fad254e).
⚠️ Report is 18 commits behind head on latest.

Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #3119      +/-   ##
==========================================
+ Coverage   73.15%   73.17%   +0.01%     
==========================================
  Files         430      430              
  Lines      103937   103967      +30     
  Branches    16717    16718       +1     
==========================================
+ Hits        76039    76076      +37     
+ Misses      27622    27615       -7     
  Partials      276      276              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants