Conversation
Latest in master for release
Latest in master 1.15
The usage of std::result_of within the header makes it impossible for this code to compile when the user uses C++20 but has HiGHS as dependency. Added a new guard to change the function signature for be compatible with C++20 and later
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## latest #3114 +/- ##
=======================================
Coverage 73.15% 73.15%
=======================================
Files 430 430
Lines 103937 103937
Branches 16717 16717
=======================================
Hits 76039 76039
Misses 27622 27622
Partials 276 276 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…with C++11 and C++20 without preprocessor checks
Collaborator
|
@galabovaa I believe these latest build errors are resolved by #3112? |
Contributor
Author
Yes, apologies for merging the wrong one! |
odow
reviewed
Jun 29, 2026
odow
left a comment
odow
left a comment
Collaborator
There was a problem hiding this comment.
There's a few different things happening here, but if the Julia tests pass I'm happy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to the julia workflow prompted by failing tests at #3110