ipo off for debug builds - #3113
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## latest #3113 +/- ##
==========================================
- Coverage 73.15% 73.15% -0.01%
==========================================
Files 430 430
Lines 103937 103937
Branches 16717 16717
==========================================
- Hits 76039 76037 -2
- Misses 27622 27624 +2
Partials 276 276 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
filikat
approved these changes
Jun 29, 2026
filikat
left a comment
filikat
left a comment
Collaborator
There was a problem hiding this comment.
It makes sense that it would slow down a bit the tests, as there is less optimization. But the times for the valgrind workflows seem to have a large variability anyway.
It's not a problem to leave this out. I just need to remember to set it manually when using the debugger.
mathgeekcoder
approved these changes
Jun 29, 2026
mathgeekcoder
left a comment
mathgeekcoder
left a comment
Collaborator
There was a problem hiding this comment.
Makes sense to me too. Debug builds aren't meant to be that fast anyhow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch off IPO for debug builds
Was causing trouble to the debugger, as spotted by @filikat
Possibly occuring now because of highs_extras?
Not super sure if we should merge this, one possible drawback is that I think it may be slowing down the valgrind tests
https://github.com/ERGO-Code/HiGHS/actions/runs/28382771311
https://github.com/ERGO-Code/HiGHS/actions/runs/28380402678
1:13 vs 1:51 in this case, but I see one 2:07 valgrind without the changes, so I am really not sure if it would affect it or just a runner feature.
What do you all think?