Skip to content

Adding --threads to command line - #3099

Merged
jajhall merged 3 commits into
latestfrom
fix-3098
Jun 27, 2026
Merged

jajhall merged 3 commits into
latestfrom
fix-3098

Conversation

@jajhall

@jajhall jajhall commented Jun 26, 2026 •

Copy link
Copy Markdown
Member

Closes #3098

And, no, I can't see how to indent the "0: automatic * default" line. CLI does this, but only does when the first character in the line is ".

@jajhall
jajhall requested a review from Opt-Mucca June 26, 2026 17:27
@jajhall jajhall self-assigned this Jun 26, 2026
@codecov

codecov Bot commented Jun 26, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.15%. Comparing base (709b30e) to head (647814c).
⚠️ Report is 10 commits behind head on latest.

Files with missing lines Patch % Lines
app/HighsRuntimeOptions.h 60.00% 4 Missing ⚠️
highs/lp_data/HighsOptions.h 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           latest    #3099   +/-   ##
=======================================
  Coverage   73.14%   73.15%           
=======================================
  Files         430      430           
  Lines      103912   103937   +25     
  Branches    16715    16717    +2     
=======================================
+ Hits        76011    76036   +25     
  Misses      27625    27625           
  Partials      276      276           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Opt-Mucca Opt-Mucca left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind the lack of indentation. Verified that everything looks good when I checkout the branch. Thanks for doing this (left for something just after making the issue....)!

@galabovaa Is this fine to be merged into latest, or does this interfere with the release?

@jajhall

jajhall commented Jun 26, 2026

Copy link
Copy Markdown
Member Author

I don't mind the lack of indentation. Verified that everything looks good when I checkout the branch. Thanks for doing this (left for something just after making the issue....)!

I need to update the documentation....

@jajhall

jajhall commented Jun 26, 2026

Copy link
Copy Markdown
Member Author

I need to update the documentation....

Done!

@jajhall
jajhall merged commit 6ad83b0 into latest Jun 27, 2026
481 of 482 checks passed
@jajhall
jajhall deleted the fix-3098 branch June 27, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants