Skip to content

Fix numpy version parsing - #3052

Merged
jajhall merged 1 commit into
ERGO-Code:fix-3052from
ValerianRey:fix-numpy-version-parsing
Jun 10, 2026
Merged

Fix numpy version parsing#3052
jajhall merged 1 commit into
ERGO-Code:fix-3052from
ValerianRey:fix-numpy-version-parsing

Conversation

@ValerianRey

Copy link
Copy Markdown
Contributor

@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.26%. Comparing base (b5383c2) to head (45142f4).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3052      +/-   ##
==========================================
- Coverage   81.27%   81.26%   -0.01%     
==========================================
  Files         358      358              
  Lines       88641    88641              
==========================================
- Hits        72042    72036       -6     
- Misses      16599    16605       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mathgeekcoder
mathgeekcoder changed the base branch from master to latest June 9, 2026 18:29

@mathgeekcoder mathgeekcoder left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@galabovaa I changed the base branch from master to latest, and it also flagged a change to CONTIBUTING.md, but seems reasonable.

@jajhall

jajhall commented Jun 9, 2026

Copy link
Copy Markdown
Member

That was my modification to CONTRIBUTING.md - about users working from latest rather than master when creating PRs! 😅

@jajhall

jajhall commented Jun 10, 2026

Copy link
Copy Markdown
Member

We need to merge this into a local branch to even view the merge conflicts

@jajhall
jajhall changed the base branch from latest to fix-3052 June 10, 2026 11:29
@jajhall
jajhall merged commit 878a3a5 into ERGO-Code:fix-3052 Jun 10, 2026
243 of 252 checks passed
@jajhall

jajhall commented Jun 10, 2026

Copy link
Copy Markdown
Member

@mathgeekcoder and @galabovaa

Having merged ValerianRey:fix-numpy-version-parsing into fix-3052 (which is a branch off master), I've tried merging latest into fix-3052. The merge conflict is small, but not one that I should try to fix. It relates to TYPE_CHECKING being replaced by

np_version = tuple(int(re.match(r'\d+', part).group()) for part in np.version.split('.'))
if sys.version_info >= (3, 9) and np_version >= (1,22,0)

Please would one of you take this form here

@mathgeekcoder

Copy link
Copy Markdown
Collaborator

The merge conflict is small, but not one that I should try to fix. It relates to TYPE_CHECKING being replaced by

Please would one of you take this form here

If it's not urgent, I can do this next week after I get back from Korea (don't have laptop here).

@mathgeekcoder mathgeekcoder mentioned this pull request Jun 24, 2026
mathgeekcoder added a commit that referenced this pull request Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: highspy incompatible with numpy pre-releases

3 participants