LP KKT check - #2815
Merged
Merged
LP KKT check#2815
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## latest #2815 +/- ##
==========================================
- Coverage 80.33% 80.25% -0.08%
==========================================
Files 348 348
Lines 86084 86159 +75
==========================================
- Hits 69152 69151 -1
- Misses 16932 17008 +76 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Thanks, this looks fine. I may need to switch off logging if I call this function to check the solution within HiPO, but we'll figure that out later.
Should we leave it as a draft, or merge it already? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code to perform the LP KKT check is now in
lpKktCheckinHighsSolution.cpp. When no basis is available,lpNoBasisKktCheckcan be called.Method computes the KKT measures in a
HighsInfoinstance, where the relative measures are calculated using the norm of "active" costs and bounds: these correspond toOn entry, if
model_statusisHighsModelStatus::kOptimalthenmax_allowed_tolerance_relative_violation(currently 100) times the corresponding tolerance, thenmodel_statusis set toHighsModelStatus::kUnknownFinish this later!