Refactor HighsCliqueTable::addClique - #2753
Merged
Merged
Conversation
Collaborator
Author
|
|
Opt-Mucca
reviewed
Jan 19, 2026
Opt-Mucca
left a comment
Collaborator
There was a problem hiding this comment.
Very nice refactor with foundCover! The code is way nicer to read now. Two questions:
- Now all substitutions are resolved before "checking" the clique. Is there any reason this wasn't done before (looks to be neater and potentially more efficient)
- I'm not understanding why the complemented inequality clique is valid here (even if it's only for size 2).
Contributor
Opt-Mucca
approved these changes
Jan 19, 2026
Opt-Mucca
left a comment
Collaborator
There was a problem hiding this comment.
Cleared up some misunderstanding on my part!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HighsCliqueTable::addCliqueand related codeHighsCliqueTable::addCliquenow checks if an equality clique with two elements is passed and automatically considers the complemented clique as well (i.e.x_1 + x_2 <= 1and(1 - x_1) + (1 - x_2) <= 1, which is useful for equality cliques identified by solution enumeration).