Skip to content

Logging clean-up - #2517

Merged
jajhall merged 5 commits into
latestfrom
fix-2515
Aug 26, 2025
Merged

jajhall merged 5 commits into
latestfrom
fix-2515

Conversation

@jajhall

@jajhall jajhall commented Aug 26, 2025

Copy link
Copy Markdown
Member

All problem dimensions now reported as rows, cols and nonzeros - with correct grammar if singular!

Eliminated duplicate code for reporting presolve reductions: all cases handled in one, and called in minimal number of locations

KKT errors reported before (nontrivial) postsolve as well as after

Renamed HighsMipSolver::runPresolve to HighsMipSolver::runMipPresolve to distinguish it from Highs::runPresolve

Cleaned up "Solving report" in MIP solver. Sub-solution (presolve/solve/postsolve) times only reported when known; "repair LP" data only printed when at least one repair LP has been solved.

Closes #2515

@jajhall
jajhall requested a review from galabovaa August 26, 2025 08:19
@codecov

codecov Bot commented Aug 26, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.30088% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.73%. Comparing base (cfd986d) to head (0263073).
⚠️ Report is 95 commits behind head on latest.

Files with missing lines Patch % Lines
highs/lp_data/HighsInterface.cpp 62.50% 9 Missing ⚠️
highs/mip/HighsMipSolver.cpp 64.28% 5 Missing ⚠️
highs/lp_data/HighsLpUtils.cpp 92.50% 3 Missing ⚠️
highs/lp_data/Highs.cpp 86.66% 2 Missing ⚠️
highs/presolve/HPresolve.cpp 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #2517      +/-   ##
==========================================
- Coverage   79.73%   79.73%   -0.01%     
==========================================
  Files         346      346              
  Lines       85976    86014      +38     
==========================================
+ Hits        68553    68582      +29     
- Misses      17423    17432       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jajhall
jajhall merged commit 7917e73 into latest Aug 26, 2025
308 checks passed
@jajhall
jajhall deleted the fix-2515 branch August 26, 2025 09:37
@jajhall jajhall mentioned this pull request Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant