Skip to content

Refactor HPresolve::dominatedColumns - #2509

Merged
jajhall merged 31 commits into
ERGO-Code:latestfrom
fwesselm:refactorPreDomChecks
Sep 19, 2025
Merged

Refactor HPresolve::dominatedColumns#2509
jajhall merged 31 commits into
ERGO-Code:latestfrom
fwesselm:refactorPreDomChecks

Conversation

@fwesselm

@fwesselm fwesselm commented Aug 20, 2025

Copy link
Copy Markdown
Collaborator
  • HPresolve::dominatedColumns contains lots of very similar / duplicate code.
  • I added some lambdas to clean this up. This should improve code coverage.
  • I ran 854 MIPs and HiGHS' behavior is not affected by these changes.

@fwesselm
fwesselm marked this pull request as draft August 20, 2025 18:20
@codecov

codecov Bot commented Aug 20, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.82716% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.67%. Comparing base (b80e8c7) to head (dd69d7a).
⚠️ Report is 33 commits behind head on latest.

Files with missing lines Patch % Lines
highs/presolve/HPresolve.cpp 92.85% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #2509      +/-   ##
==========================================
+ Coverage   79.64%   79.67%   +0.02%     
==========================================
  Files         346      346              
  Lines       86488    86424      -64     
==========================================
- Hits        68886    68855      -31     
+ Misses      17602    17569      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fwesselm
fwesselm marked this pull request as ready for review August 22, 2025 06:19
@fwesselm
fwesselm requested a review from Opt-Mucca August 22, 2025 06:19

@Opt-Mucca Opt-Mucca left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice change!

Using size_t for i in a loop to later index stuff, e.g. x[i], feels a bit wrong, but I've got no practical problem with it. Aside from the request to add an additional comment I'm happy with everything (it definitely improves the readability)

Comment thread highs/presolve/HPresolve.cpp
Comment thread highs/presolve/HPresolve.cpp
@jajhall

jajhall commented Sep 19, 2025

Copy link
Copy Markdown
Member

Sorry: missed the fact that these changes had been approved and tested

@jajhall
jajhall merged commit 0859510 into ERGO-Code:latest Sep 19, 2025
196 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants