Skip to content

Warnings g++ linux - #2495

Merged
jajhall merged 4 commits into
latestfrom
warnings-gcc
Aug 20, 2025
Merged

Warnings g++ linux #2495
jajhall merged 4 commits into
latestfrom
warnings-gcc

Conversation

@galabovaa

Copy link
Copy Markdown
Contributor

Some warnings popping up with g++ on linux

@galabovaa
galabovaa requested a review from jajhall August 13, 2025 14:58
@codecov

codecov Bot commented Aug 13, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.73%. Comparing base (7e6e14b) to head (c5767f8).
⚠️ Report is 23 commits behind head on latest.

Additional details and impacted files
@@           Coverage Diff           @@
##           latest    #2495   +/-   ##
=======================================
  Coverage   79.72%   79.73%           
=======================================
  Files         346      346           
  Lines       85939    85949   +10     
=======================================
+ Hits        68519    68528    +9     
- Misses      17420    17421    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jajhall jajhall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fwesselm seems to want static_cast<HighsInt>(fred) rather than HighsInt(fred) (or) (HighsInt)fred: not that I know the difference between the three, other than HighsInt(fred) possibly being more modern than (HighsInt)fred!

Otherwise OK

@fwesselm

Copy link
Copy Markdown
Collaborator

@fwesselm seems to want static_cast<HighsInt>(fred) rather than HighsInt(fred) (or) (HighsInt)fred: not that I know the difference between the three, other than HighsInt(fred) possibly being more modern than (HighsInt)fred!

Otherwise OK

As far as I understand, C++ style casts (static_cast etc.) are checked at compile-time. I think these also express the intent more clearly (compared to C style casts).

@jajhall
jajhall merged commit dc5dca0 into latest Aug 20, 2025
368 of 369 checks passed
@galabovaa
galabovaa deleted the warnings-gcc branch August 28, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants