Small addition to row presolve - #2491
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## latest #2491 +/- ##
=======================================
Coverage 79.59% 79.59%
=======================================
Files 346 346
Lines 85838 85890 +52
=======================================
+ Hits 68321 68363 +42
- Misses 17517 17527 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Opt-Mucca
approved these changes
Aug 12, 2025
Opt-Mucca
left a comment
Collaborator
There was a problem hiding this comment.
Had to play around with some pen and paper a bit to check everything (well done on keeping track of all the signs), but looks good!
I'd assume that presolve was already catching most of these cases, but I guess things like probing have a budget and wouldn't catch everything. This should definitely be merged if it is performance improving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HPresolve::rowPresolvethat fixes a binary variable to one of its bounds if (tentatively) setting it to the opposite bound makes the problem infeasible.