Skip to content

Small addition to row presolve - #2491

Merged
jajhall merged 5 commits into
ERGO-Code:latestfrom
fwesselm:simpleDegree1Tests
Aug 13, 2025
Merged

Small addition to row presolve#2491
jajhall merged 5 commits into
ERGO-Code:latestfrom
fwesselm:simpleDegree1Tests

Conversation

@fwesselm

Copy link
Copy Markdown
Collaborator
  • Add a simple test to HPresolve::rowPresolve that fixes a binary variable to one of its bounds if (tentatively) setting it to the opposite bound makes the problem infeasible.
  • This is a special case of general bound tightening.
  • Unfortunately, the effect on performance in terms of geometric means of running times and numbers of branching nodes is very small. However, it may still be useful for certain models.

@codecov

codecov Bot commented Aug 11, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.59%. Comparing base (c6a70c5) to head (0152f99).
⚠️ Report is 32 commits behind head on latest.

Additional details and impacted files
@@           Coverage Diff           @@
##           latest    #2491   +/-   ##
=======================================
  Coverage   79.59%   79.59%           
=======================================
  Files         346      346           
  Lines       85838    85890   +52     
=======================================
+ Hits        68321    68363   +42     
- Misses      17517    17527   +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Opt-Mucca Opt-Mucca left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to play around with some pen and paper a bit to check everything (well done on keeping track of all the signs), but looks good!

I'd assume that presolve was already catching most of these cases, but I guess things like probing have a budget and wouldn't catch everything. This should definitely be merged if it is performance improving.

Comment thread highs/presolve/HPresolve.cpp
@jajhall
jajhall merged commit 9e4d8c4 into ERGO-Code:latest Aug 13, 2025
198 of 199 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants