Skip to content

Clean up Feasibility Jump logging - #2484

Merged
jajhall merged 5 commits into
latestfrom
bc/fj-logging
Aug 1, 2025
Merged

Clean up Feasibility Jump logging#2484
jajhall merged 5 commits into
latestfrom
bc/fj-logging

Conversation

@BenChampion

Copy link
Copy Markdown
Collaborator

Minor change making Feasibility Jump (FJ) use the HiGHS logging calls rather than printf. Because HiGHS sets log_options correctly for submips, we no longer need FJ's internal verbosity parameter.

I also adjusted the logging levels for the different messages to make them more sensible.

@codecov

codecov Bot commented Aug 1, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.56%. Comparing base (ebd83e1) to head (03eceed).
⚠️ Report is 7 commits behind head on latest.

Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #2484      +/-   ##
==========================================
+ Coverage   79.55%   79.56%   +0.01%     
==========================================
  Files         346      346              
  Lines       85401    85399       -2     
==========================================
+ Hits        67942    67951       +9     
+ Misses      17459    17448      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Opt-Mucca Opt-Mucca left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change!

@jajhall jajhall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jajhall
jajhall merged commit 6f57c32 into latest Aug 1, 2025
306 checks passed
@BenChampion
BenChampion deleted the bc/fj-logging branch August 4, 2025 09:13
BenChampion added a commit that referenced this pull request Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants