Add a curve variant that isolates the PEM Faraday term - #165
Merged
Conversation
The baseline 'ulleberg' PEM row was generated before the PEM half was rebuilt and carries no Faraday term at all. It assumes every electron makes hydrogen at every load, which is not physical, and Yodwong et al. 2020 measured the loss directly. Against the current derivation the baseline understates PEM's specific consumption by 24 per cent at 5 per cent load, 13 per cent at 8 and 7 per cent at 14 - exactly the deep turn-down range PEM is valued for. Figure 1 in the paper already draws the corrected curve, so the figure, the text and the model currently disagree, and the model is the one that is wrong. This adds 'ulleberg_pemfaraday': baseline alkaline, PEM with its crossover term. The existing 'ulleberg_conservative' moves both technologies at once and cannot say which did the work, so it cannot answer whether the baseline needs replacing. Nothing already run is affected, because the baseline row is untouched. Verified: both columns of the new entry reproduce analysis/electrolyser_curve.py.
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additive. Nothing already run changes.
The problem
The baseline
ullebergPEM column was generated before the PEM half was rebuilt, and it carries no Faraday term at all. It assumes every electron makes hydrogen at every load.That is not physical, and it is not what the paper says. Yodwong et al. 2020 measured the crossover directly on a PEM cell at three pressures, and
analysis/electrolyser_curve.pynow models it. Reproducing the baseline row requires deleting the Faraday term from the derivation entirely — confirmed to 2e-4.What the baseline understates:
That is exactly the deep turn-down range PEM is valued for, and PEM is the technology under test — so the baseline flatters it where it matters most.
Figure 1(a) of the paper already draws the corrected curve. So the figure, the manuscript text and the model currently disagree, and the model is the one that is wrong.
Why a new variant rather than fixing the baseline
ulleberg_conservativealready has the corrected PEM column, but it also swaps alkaline's Faraday parameters from Ulleberg to Sánchez. It moves both technologies at once, so it cannot say which one did the work.ulleberg_pemfaradayis baseline alkaline plus corrected PEM. One change. It answers whether the baseline needs replacing, and at the cost of a single solve rather than a full campaign.If the answer is that it matters, the baseline row gets replaced in a follow-up and the campaign runs again. If it does not, the completed campaign stands and the corrected curve is reported as a sensitivity.
Verification
Both columns of the new entry reproduce
analysis/electrolyser_curve.pyto better than 5e-4. The baseline, the two balance-of-plant variants and the conservative set are untouched.