Reject duty-only properties on non-Duty rules - #244
Merged
Conversation
jgeluk
requested review from
FroehlichMarcel,
joshcornejo,
matthiasautrata,
rivettp and
tonyseale
as code owners
August 19, 2026 17:10
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #239.
This is intentionally stacked on #234 because the acceptance criteria require the Schedule model introduced there. Once #234 is merged, this branch can be rebased onto
developand the PR base changed.Changes
odrl:Dutytypedprod:recurrencedprod:scheduleremains valid on non-Duty resourcesVerification
python -m unittest discover -s dprod-contracts/tests(48 tests)python -m unittest discover -s tests(2 tests)python dprod-contracts/validate.pypython spec-generator/main.pygit diff --check