Match marine forecast polygons by area name instead of meteocode lookup - #518
Merged
tomkralidis merged 1 commit intoJul 28, 2026
Conversation
Dukestep
marked this pull request as ready for review
July 27, 2026 17:53
Dukestep
force-pushed
the
update-marine-weather-area-info-setting
branch
from
July 27, 2026 17:55
03a2f58 to
f32bd6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures the marine forecast polygons refered to in a marine weather XML file is matched by area name rather than via the meteocode lookup. This removes the need to use a lookup table (which has fallen out of sync) and ensures any references to updated marine forecast polygons can resolve once the associated marine weather forecase polygon ES collection is also updated.