The dashgo_d1 package for Ubuntu 20.04 and ROS noetic - #3
Open
m11112089 wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2
Could you review these changes and provide feedback,please. I believe these updates will enhance the dashgo_d1 driver's compatibility and maintainability on ROS Noetic.
1.In python3, the return value of map() is no longer list, but iterators, you have to convert iterators to list.
2.Python3's string is Unicode, python2.7 is ascii, so we need to encode the string sent to Arduino into ascii, and decode the string received from Arduino into Unicode.
3.thread should be changed to _thread (Low-level threading API).
4.Python 3 disallows mixing the use of tabs and spaces for indentation.
5.Delete yocs_velocity_smoother and change from smoother_cmd_vel to cmd_vel.
6.Python3 print need to add parentheses.