LyricsPlus & BetterLyrics providers, provider order, embedded-lyrics detection, batch UI overhaul - #7
Merged
DynamycSound merged 1 commit intoJul 16, 2026
Conversation
…ics detection, batch UI overhaul - Add LyricsPlus provider (issue #4): 6 community mirrors, word-by-word (enhanced LRC) and line-synced output, remembers the last working mirror - Add BetterLyrics provider (issue #4): Apple-style TTML from lyrics-api.boidu.dev parsed by a new pure-Kotlin TTML parser with syllable merging, agents and background vocals - Both are direct-fetch providers wired into the smart matcher with a duration-verified confidence cap, and into the single-song/quick-search flows - Fix embedded-lyrics detection (issue #5): the home page scan now reads lyrics embedded in the audio tags (memoised TagLib reader), so embedded-only tracks no longer show as missing; batch skip-existing honours embedded synced lyrics too - User-configurable provider fallback chain (issue #6): new Settings section to reorder/disable providers; batch and single-song searches walk that exact chain - Batch download options are now a full page with a Start button instead of a popup dialog - Synced/Unsynced/Not found/Failed counters on the batch progress screen are tappable and open a half-screen drawer (draggable to full) listing the affected songs; tapping a song previews its lyrics Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012b5krdonsAyKdwbAjhFxP8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements issues #4, #5 and #6, plus two batch-download UI improvements.
Issue #4 — LyricsPlus & BetterLyrics providers (word-by-word / TTML)
LyricsPlusAPI): queries/v2/lyrics/getacross the 6 community mirrors from the issue, remembering the last working one. "Word" responses are converted into the app's enhanced-LRC dialect ([mm:ss.SSS]line stamps +<begin>word <end>inline timing, same shape as the Apple/QQ output), withv1:/v2:voice tags and[bg:...]background blocks in multi-person mode. "Line" responses become regular synced LRC.BetterLyricsAPI): fetches Apple-style TTML fromlyrics-api.boidu.devand converts it via a new pure-KotlinTtmlLyricsParser(word spans, syllable merging,ttm:agentvoices,x-bgbackground vocals; translation/romanization spans skipped).searchDirectpath: a hit may only auto-accept when the local duration was sent along (the service verified the length); otherwise it's capped at REVIEW. They also work as the selected provider in the single-song and quick-search flows.Issue #5 — embedded lyrics not detected on the home page
EmbeddedLyricsreader: reads theLYRICS/USLT tag via TagLib, memoised per file on(lastModified, length)so the full-library rescan on every Home resume stays cheap.LrcPrescangained an injectable embedded-lyrics fallback (newEMBEDDED_SYNCED/EMBEDDED_UNSYNCEDresults): a track with embedded synced lyrics now shows under "Has lyrics", and an embedded synced body outranks a plain sidecar.lrc.Issue #6 — provider fallback chain in user-defined order
Batch download UI
Tests
TtmlLyricsParserTest(parsing, syllable merging, LRC output, time formats),EmbeddedLyricsPrescanTest(embedded fallback precedence),ProviderOrderParsingTest(persistence round-trip).testDebugUnitTest: 70 tests, all green except the pre-existingSuicideboysMatchTest, which queries the live LRCLib API and fails in this sandboxed environment independent of this diff.Closes #4, closes #5, closes #6.
🤖 Generated with Claude Code
https://claude.ai/code/session_012b5krdonsAyKdwbAjhFxP8
Generated by Claude Code