Skip to content

Add Pixi to the repo#67

Open
IamPhytan wants to merge 2 commits into
Dynamium-Lab:mainfrom
IamPhytan:pixi-integration
Open

Add Pixi to the repo#67
IamPhytan wants to merge 2 commits into
Dynamium-Lab:mainfrom
IamPhytan:pixi-integration

Conversation

@IamPhytan

Copy link
Copy Markdown

Added Pixi to build the repo examples.

You can use Pixi with the following commands:

pixi run build-examples
# Run any example (ex: example-01)
pixi run example-01

blast-py is also available as a Python library when running pixi shell

$ pixi run python
>>> import blast
>>> blast.ManipulatorLimits()
<blast._blast_core.ManipulatorLimits object at 0x788a44f3f130>

Comment thread examples/CMakeLists.txt

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you have trouble building or running? If so, please open an issue with specific platform details.

@gallantandre

Copy link
Copy Markdown
Member

Thanks for the contribution. A few concerns before we merge this:

  • Linux only. The pixi.lock file only covers linux-64, but the project already supports Windows and macOS as first-class targets (including the Python bindings). This adds no value for Windows users and would give new contributors a false impression that Pixi is the intended way to build on all platforms.
  • Redundant with the existing setup. The repo already works out of the box with cmake -B build && cmake --build build. Dependencies are either vendored in extern/ or fetched via FetchContent. Adding a second parallel environment manager increases maintenance surface without a clear gain.
  • Noisy lockfile. pixi.lock is 700+ lines and will produce large diffs on every dependency update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants