[IMP] password_security: use ir.config_parameter#1
Closed
alexis-via wants to merge 1 commit into
Closed
Conversation
Author
|
This PR aims at updating the v17 OCA migration PR OCA#610 |
Replace fields on res.company by ir.config_parameter Remove dead test for v16 migration script
dc7b86d to
f9cf363
Compare
Author
|
I implemented what I proposed in my comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace fields on res.company by ir.config_parameter.
Remove dead test for v16 migration script.
There is one problem with this implementation: in odoo, when you set an integer ir.config_parameter to 0, the ir.config_parameter is deleted... so Odoo will use the default value. If the default value is 0 like auth_password_policy.minlength in the module auth_password_policy of the official addons, it's OK. But, in the module password_security, the default value is NOT 0.
I propose the following:
If you agree with my proposal, I'll implement it in this PR.