Skip to content

changes to order id #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
murrayk4 wants to merge 6 commits into
base: main
Choose a base branch
from
Open

changes to order id #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
643afec
test ci enablement prep
Aug 14, 2025
c358392
add model file
Aug 14, 2025
7d9ea87
amended test bounds
Aug 14, 2025
0b35337
test changes
Aug 14, 2025
934b0eb
Merge pull request #1 from murrayk4/dev-super-admin-rpqc
murrayk4 Aug 14, 2025
4c50771
changes made to tests
Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added .gitkeep
View file
Open in desktop
Empty file.
6 changes: 3 additions & 3 deletions ci_enablement.model.lkml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
connection: "bq_faa"
connection: "sample_bigquery_connection"

include: "/views/dimensions/dim_products.view.lkml"
include: "/views/dimensions/dim_users.view.lkml"
Expand Down Expand Up @@ -39,7 +39,7 @@ test: orders_items_2021 {
filters: [order_items.created_year: "2021"]
}
assert: matches_historic_lower_bound {
expression: ${order_items.count_order_items} > 13000 ;;
expression: ${order_items.count_order_items} > 10000 ;;
}
assert: matches_historic_upper_bound {
expression: ${order_items.count_order_items} < 14000 ;;
Expand All @@ -54,7 +54,7 @@ test: orders_items_2020 {
filters: [order_items.created_year: "2020"]
}
assert: matches_historic_lower_bound {
expression: ${order_items.count_order_items} > 7000 ;;
expression: ${order_items.count_order_items} > 5000 ;;
}
assert: matches_historic_upper_bound {
expression: ${order_items.count_order_items} < 8000 ;;
Expand Down
17 changes: 16 additions & 1 deletion views/facts/fct_order_items.view.lkml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,27 @@ view: fct_order_items {

# Step 1: Update id -> order_item_id

dimension: id {
dimension: order_item_id {
primary_key: yes
type: number
sql: ${TABLE}.id ;;
}

dimension_group: delivered {
type: time
description: "The date/timestamp the line item was created."
timeframes: [
raw,
time,
date,
week,
month,
quarter,
year
]
sql: ${TABLE}.delivered ;;
}

dimension_group: created {
type: time
description: "The date/timestamp the line item was created."
Expand Down