Skip to content

February 27th Testing #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DylanBaker wants to merge 2 commits into
base: main
Choose a base branch
from
+18 −3
Open

February 27th Testing #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9a7175
breaking things
Feb 27, 2026
8865468
Update delivered to be of type time
Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ci_enablement.model.lkml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@ test: orders_items_2021 {
filters: [order_items.created_year: "2021"]
}
assert: matches_historic_lower_bound {
expression: ${order_items.count_order_items} > 10000 ;;
expression: ${order_items.count_order_items} > 10 ;;
}
assert: matches_historic_upper_bound {
expression: ${order_items.count_order_items} < 14000 ;;
expression: ${order_items.count_order_items} < 14 ;;
}
}

Expand Down
17 changes: 16 additions & 1 deletion views/facts/fct_order_items.view.lkml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ view: fct_order_items {

# Step 1: Update id -> order_item_id

dimension: id {
dimension: order_item_id {
primary_key: yes
type: number
sql: ${TABLE}.id ;;
Expand All @@ -28,6 +28,21 @@ view: fct_order_items {

# Step 2: Add delivered_at dimension_group

dimension_group: delivered {
type: time
description: "The date/timestamp the line item was delivered."
timeframes: [
raw,
time,
date,
week,
month,
quarter,
year
]
sql: ${TABLE}.delivered ;;
}

dimension: order_id {
type: number
description: "The ID of the associated order."
Expand Down