Extension/swap and deposit - #128
Open
shafu0x wants to merge 35 commits into
Open
Conversation
v1.0.0
coffee-the-dev
left a comment
coffee-the-dev
left a comment
Contributor
There was a problem hiding this comment.
We should use paraswap to execute the swap (see collateral swap extension) as it aggregates across many DEXes. Not all of our collaterals have deep uniswap liquidity, some have more in curve, balancer, etc.
Contributor
|
We should also add a native ETH route to SwapAndDeposit that wraps to WETH for the swap |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.