Skip to content

chore: resolve remaining repository checker findings - #171

Merged
DutchmanNL merged 1 commit into
mainfrom
chore/checker-wave2
Aug 24, 2026
Merged

chore: resolve remaining repository checker findings#171
DutchmanNL merged 1 commit into
mainfrom
chore/checker-wave2

Conversation

@DutchmanNL

Copy link
Copy Markdown
Contributor

Second wave of ioBroker repository checker cleanup, against the current body of #136.

Codes fixed

Code Fix
E0040 "ioBroker" added to package.json keywords
E0063 removed chai, chai-as-promised, mocha, sinon, sinon-chai and their @types from devDependencies (bundled by @iobroker/testing v5)
E1027 / E1034 / E1054 Ukrainian (uk) added to common.titleLang, common.desc and both common.news entries
E5010 / W5603 new admin/i18n/uk/translations.json
E1057 js-controller >=6.0.11, admin >=7.6.20
E4041 io-package.json schema URL corrected in .vscode/settings.json
W4042 jsonConfig schema mapping added to .vscode/settings.json
E5005 this.setTimeout() / this.clearTimeout() for the data-refresh timers
E5043 node:crypto, node:https, node:util
E5509 / E5510 interval number fields now use xs 12 >= sm 6 >= md 4 >= lg 3 >= xl 2; all six items were adjusted, so the truncated E5510 list should be covered
E5612 "Secret Key" label key added to every admin/i18n/*/translations.json
E6026 / E6029 / W6027 / W6030 ## Support me moved above ## Changelog so the ### version entries (including 0.1.2) sit inside the changelog section again; the stray ### coming soon heading folded into ### __WORK IN PROGRESS__
E9006 .commitinfo added to .gitignore
W5047 legacy admin UI removed (admin/index_m.html, admin/style.css, and the now-orphaned admin/words.js)
W5057 / W5058 secretKey declared in native, protectedNative and encryptedNative
W6023 standard Sentry notice added near the top of README.md

Extra (not a checker code): typescript bumped to ^5.9.3 and types: ["node", "mocha"] restored in tsconfig.check.jsonnpm run check was failing on main with 6 errors (TS 4.9 cannot parse the lib entries of @tsconfig/node22) and is now clean.

Bot issues

#137 (Node.js 24) and #138 (@iobroker/adapter-core) are satisfied by the current main and have been closed. #135 (ESLint 9 / @iobroker/eslint-config) is also already implemented and was closed.

Leftovers

Code Why
W3009 / E3009 the concurrency: block deliberately deviates from upstream: release runs triggered by a tag are never cancelled, because cancelling them aborts the deploy job and leaves a half-finished release (which the checker then reports as W3032). Accepted, documented deviation.
E2008 npm provenance / trusted publishing — needs an action on npmjs.com, not in the repo
E3032 / W8005 only clears once a new release is cut and the tag workflow run exists
W4001 adapter is not in the ioBroker latest repository yet — needs a PR to ioBroker.repositories
W0076 prettier.config.mjs is missing. Adding it activates the ioBroker prettier ruleset inside eslint, which turns the whole code base into ~985 lint errors (4-space indent / single quotes vs. the current prettier defaults). That is a mechanical eslint . --fix reformat, but it would bury this PR under a ~1000 line diff, so it is left for a dedicated formatting commit.
W6020 CHANGELOG_OLD.md — optional, only 3 released versions so far
S5601 short i18n format ({lang}.json) — optional migration

Local verification

  • npm install --no-audit --no-fund (clean tree, lockfile regenerated) — ok
  • npm run lint — 0 errors, 5 pre-existing jsdoc warnings
  • npm run check — clean (was 6 errors on main)
  • npm run test:package — 57 passing
  • npm run test:js — 1 passing
  • npm run test:integration — 1 passing, adapter starts and terminates cleanly on js-controller 7.2.3 / Node 24

🤖 Generated with Claude Code

Second-wave cleanup for the ioBroker repository checker issue #136.

Errors fixed:
- E0040: add "ioBroker" to package.json keywords
- E0063: drop chai, chai-as-promised, mocha, sinon, sinon-chai and their
  @types from devDependencies (bundled by @iobroker/testing v5)
- E1027 / E1034 / E1054 / E5010 / W5603: add Ukrainian (uk) translations for
  common.titleLang, common.desc and common.news plus admin/i18n/uk
- E1057: raise js-controller floor to >=6.0.11 and admin to >=7.6.20
- E4041 / W4042: correct the io-package.json schema URL and add the
  jsonConfig schema mapping in .vscode/settings.json
- E5005: use this.setTimeout() / this.clearTimeout() so the refresh timers
  are cleared automatically on unload
- E5043: require node:crypto, node:https and node:util
- E5509 / E5510: responsive sizes of the interval number fields no longer
  grow towards larger breakpoints (xs 12 >= sm 6 >= md 4 >= lg 3 >= xl 2)
- E5612: add the "Secret Key" label key to all admin translation files
- E6026 / E6029 / W6027 / W6030: move "Support me" out of the changelog
  section so the "###" version entries (incl. 0.1.2) belong to it again
- E9006: ignore .commitinfo

Warnings fixed:
- W5047: remove the unused legacy admin UI (index_m.html, style.css,
  words.js) now that jsonConfig is used
- W5057 / W5058: declare secretKey in native, protectedNative and
  encryptedNative
- W6023: add the standard Sentry notice to README.md

Also bumps typescript to ^5.9.3 and restores the mocha globals in
tsconfig.check.json, so "npm run check" passes again.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@DutchmanNL
DutchmanNL merged commit 85281b3 into main Aug 24, 2026
9 checks passed
@DutchmanNL
DutchmanNL deleted the chore/checker-wave2 branch August 24, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant