chore: resolve remaining repository checker findings - #171
Merged
Conversation
Second-wave cleanup for the ioBroker repository checker issue #136. Errors fixed: - E0040: add "ioBroker" to package.json keywords - E0063: drop chai, chai-as-promised, mocha, sinon, sinon-chai and their @types from devDependencies (bundled by @iobroker/testing v5) - E1027 / E1034 / E1054 / E5010 / W5603: add Ukrainian (uk) translations for common.titleLang, common.desc and common.news plus admin/i18n/uk - E1057: raise js-controller floor to >=6.0.11 and admin to >=7.6.20 - E4041 / W4042: correct the io-package.json schema URL and add the jsonConfig schema mapping in .vscode/settings.json - E5005: use this.setTimeout() / this.clearTimeout() so the refresh timers are cleared automatically on unload - E5043: require node:crypto, node:https and node:util - E5509 / E5510: responsive sizes of the interval number fields no longer grow towards larger breakpoints (xs 12 >= sm 6 >= md 4 >= lg 3 >= xl 2) - E5612: add the "Secret Key" label key to all admin translation files - E6026 / E6029 / W6027 / W6030: move "Support me" out of the changelog section so the "###" version entries (incl. 0.1.2) belong to it again - E9006: ignore .commitinfo Warnings fixed: - W5047: remove the unused legacy admin UI (index_m.html, style.css, words.js) now that jsonConfig is used - W5057 / W5058: declare secretKey in native, protectedNative and encryptedNative - W6023: add the standard Sentry notice to README.md Also bumps typescript to ^5.9.3 and restores the mocha globals in tsconfig.check.json, so "npm run check" passes again. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second wave of ioBroker repository checker cleanup, against the current body of #136.
Codes fixed
"ioBroker"added topackage.jsonkeywordschai,chai-as-promised,mocha,sinon,sinon-chaiand their@typesfrom devDependencies (bundled by@iobroker/testingv5)uk) added tocommon.titleLang,common.descand bothcommon.newsentriesadmin/i18n/uk/translations.jsonjs-controller >=6.0.11,admin >=7.6.20.vscode/settings.json.vscode/settings.jsonthis.setTimeout()/this.clearTimeout()for the data-refresh timersnode:crypto,node:https,node:utilxs 12 >= sm 6 >= md 4 >= lg 3 >= xl 2; all six items were adjusted, so the truncated E5510 list should be covered"Secret Key"label key added to everyadmin/i18n/*/translations.json## Support memoved above## Changelogso the###version entries (including 0.1.2) sit inside the changelog section again; the stray### coming soonheading folded into### __WORK IN PROGRESS__.commitinfoadded to.gitignoreadmin/index_m.html,admin/style.css, and the now-orphanedadmin/words.js)secretKeydeclared innative,protectedNativeandencryptedNativeREADME.mdExtra (not a checker code):
typescriptbumped to^5.9.3andtypes: ["node", "mocha"]restored intsconfig.check.json—npm run checkwas failing on main with 6 errors (TS 4.9 cannot parse thelibentries of@tsconfig/node22) and is now clean.Bot issues
#137 (Node.js 24) and #138 (
@iobroker/adapter-core) are satisfied by the current main and have been closed. #135 (ESLint 9 /@iobroker/eslint-config) is also already implemented and was closed.Leftovers
concurrency:block deliberately deviates from upstream: release runs triggered by a tag are never cancelled, because cancelling them aborts the deploy job and leaves a half-finished release (which the checker then reports as W3032). Accepted, documented deviation.latestrepository yet — needs a PR toioBroker.repositoriesprettier.config.mjsis missing. Adding it activates the ioBroker prettier ruleset insideeslint, which turns the whole code base into ~985 lint errors (4-space indent / single quotes vs. the current prettier defaults). That is a mechanicaleslint . --fixreformat, but it would bury this PR under a ~1000 line diff, so it is left for a dedicated formatting commit.CHANGELOG_OLD.md— optional, only 3 released versions so far{lang}.json) — optional migrationLocal verification
npm install --no-audit --no-fund(clean tree, lockfile regenerated) — oknpm run lint— 0 errors, 5 pre-existing jsdoc warningsnpm run check— clean (was 6 errors on main)npm run test:package— 57 passingnpm run test:js— 1 passingnpm run test:integration— 1 passing, adapter starts and terminates cleanly on js-controller 7.2.3 / Node 24🤖 Generated with Claude Code