Skip to content

fix error when device offline - #478

Open
arteck wants to merge 12 commits into
DrozmotiX:mainfrom
arteck:main
Open

fix error when device offline #478
arteck wants to merge 12 commits into
DrozmotiX:mainfrom
arteck:main

Conversation

@arteck

@arteck arteck commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI lite review requested due to automatic review settings August 20, 2026 05:50
Copilot AI reviewed Aug 20, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • main.js: Generated file

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@arteck

arteck commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

error message
Connection issue for Wechselrichter Temperatur Error: Not connected | Error: Not connected at EsphomeNativeApiConnection.subscribeStatesService (/opt/iobroker/node_modules/@2colors/esphome-native-api/lib/connection.js:283:36) at EsphomeNativeApiClient.<anonymous> (/opt/iobroker/node_modules/iobroker.esphome/main.js:801:65)
fixed

@DutchmanNL

DutchmanNL commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

@SimonFischer04 den hier kennen wir am besten noch mitnehmen vor dem stable, magst du auch Reviewen ?

SimonFischer04
SimonFischer04 reviewed Aug 24, 2026
View reviewed changes
Comment thread main.js
!clientDetails[deviceIP].client.connection
) {
this.log.debug(`[onStateChange] Device ${deviceName} not connected, acknowledging state change`);
await this.setStateAsync(id, { val: state.val, ack: true });

@SimonFischer04 SimonFischer04 Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warum wird hier ein state acknowledged, der explizit nicht zum device gesendet wird?
Ist das nicht genau der Sinn von ack?

@SimonFischer04 SimonFischer04 Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eigentlich kann der ganze change block hier wieder komplett weg.

Dan PR ok von meiner Seite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SimonFischer04 SimonFischer04 SimonFischer04 left review comments
Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arteck @DutchmanNL @SimonFischer04