Adopt ESLint --max-warnings 0 instructions from ioBroker.esphome - #96
Conversation
…e PR #407 Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com>
There was a problem hiding this comment.
@copilot you forgot the version tag
There was a problem hiding this comment.
Added the ## [0.5.7] - 2026-02-21 version tag in commit 51a166b.
There was a problem hiding this comment.
Pull request overview
This PR updates the template’s ESLint guidance to align with CI behavior that enforces --max-warnings 0 (treat warnings as errors), and bumps the template version accordingly.
Changes:
- Update the template’s recommended
lintscript toeslint --max-warnings 0 .and clarify best practices to fix warnings (not just errors). - Bump version references from
0.5.6→0.5.7across template/docs/metadata. - Add WORK IN PROGRESS changelog entries describing the ESLint guidance change.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| template.md | Updates ESLint script example and best-practices wording to enforce --max-warnings 0. |
| CHANGELOG.md | Adds WIP entries describing the ESLint guidance update. |
| package.json | Bumps repository version to 0.5.7. |
| config/metadata.json | Syncs metadata/template version to 0.5.7. |
| README.md | Updates documented template version snippet to 0.5.7. |
| .github/copilot-instructions.md | Bumps instructions file version to 0.5.7. |
|
|
||
| ## **WORK IN PROGRESS** | ||
|
|
||
| - (copilot) **ENHANCED**: Updated ESLint instructions to use `--max-warnings 0` flag, treating warnings as errors consistent with CI behavior (Fixes #94) |
There was a problem hiding this comment.
| ## **WORK IN PROGRESS** | ||
|
|
||
| - (copilot) **ENHANCED**: Updated ESLint instructions to use `--max-warnings 0` flag, treating warnings as errors consistent with CI behavior (Fixes #94) | ||
| - (copilot) **ENHANCED**: Added best practice to run `./node_modules/.bin/eslint --max-warnings 0 .` locally to match CI behavior |
There was a problem hiding this comment.
This WORK IN PROGRESS entry doesn’t follow the documented changelog format (it’s missing a “(Fixes #XX)” reference), and it suggests running the eslint binary directly even though the template guidance now says to use npm run lint to match CI. Consider updating this line to match the template wording and include the issue reference.
| - (copilot) **ENHANCED**: Added best practice to run `./node_modules/.bin/eslint --max-warnings 0 .` locally to match CI behavior | |
| - (copilot) **ENHANCED**: Added best practice to run `npm run lint` locally to match CI behavior (Fixes #95) |
Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com>
template.mdESLintlintscript to useeslint --max-warnings 0 .--max-warnings 0)## [0.5.7] - 2026-02-21version tagOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.