Skip to content

Adopt ESLint --max-warnings 0 instructions from ioBroker.esphome - #96

Merged
DutchmanNL merged 3 commits into
mainfrom
copilot/adopt-eslint-instructions
Feb 25, 2026
Merged

Adopt ESLint --max-warnings 0 instructions from ioBroker.esphome#96
DutchmanNL merged 3 commits into
mainfrom
copilot/adopt-eslint-instructions

Conversation

Copilot AI commented Feb 21, 2026

Copy link
Copy Markdown
Contributor
  • Update template.md ESLint lint script to use eslint --max-warnings 0 .
  • Update ESLint Best Practices item 1 to emphasize fixing ALL warnings, not just errors
  • Add Best Practices item 6 noting CI treats warnings as errors (--max-warnings 0)
  • Bump version to 0.5.7
  • Update CHANGELOG.md with proper ## [0.5.7] - 2026-02-21 version tag
  • Run tests and verify all pass
Original prompt

This section details on the original issue you should resolve

<issue_title>Adopt ESLint instructions</issue_title>
<issue_description>Adopt changes in instructions from: https://github.com/DrozmotiX/ioBroker.esphome/pull/407/changes#diff-227c2c26cb2ee0ce0f46a320fc48fbcbdf21801a57f59161b1d0861e8aad55f5</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…e PR #407

Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com>
Copilot AI changed the title [WIP] Adopt ESLint instructions from recent changes Adopt ESLint --max-warnings 0 instructions from ioBroker.esphome Feb 21, 2026
Copilot AI requested a review from DutchmanNL February 21, 2026 22:30
@DutchmanNL
DutchmanNL marked this pull request as ready for review February 21, 2026 22:54
Copilot AI review requested due to automatic review settings February 21, 2026 22:54
Comment thread CHANGELOG.md

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot you forgot the version tag

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the ## [0.5.7] - 2026-02-21 version tag in commit 51a166b.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the template’s ESLint guidance to align with CI behavior that enforces --max-warnings 0 (treat warnings as errors), and bumps the template version accordingly.

Changes:

  • Update the template’s recommended lint script to eslint --max-warnings 0 . and clarify best practices to fix warnings (not just errors).
  • Bump version references from 0.5.60.5.7 across template/docs/metadata.
  • Add WORK IN PROGRESS changelog entries describing the ESLint guidance change.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
template.md Updates ESLint script example and best-practices wording to enforce --max-warnings 0.
CHANGELOG.md Adds WIP entries describing the ESLint guidance update.
package.json Bumps repository version to 0.5.7.
config/metadata.json Syncs metadata/template version to 0.5.7.
README.md Updates documented template version snippet to 0.5.7.
.github/copilot-instructions.md Bumps instructions file version to 0.5.7.

Comment thread CHANGELOG.md

## **WORK IN PROGRESS**

- (copilot) **ENHANCED**: Updated ESLint instructions to use `--max-warnings 0` flag, treating warnings as errors consistent with CI behavior (Fixes #94)

Copilot AI Feb 21, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog entry references “Fixes #94”, but the PR metadata indicates this change should fix #95. Please update the issue reference so the changelog links to the correct issue.

Copilot uses AI. Check for mistakes.
Comment thread CHANGELOG.md Outdated
## **WORK IN PROGRESS**

- (copilot) **ENHANCED**: Updated ESLint instructions to use `--max-warnings 0` flag, treating warnings as errors consistent with CI behavior (Fixes #94)
- (copilot) **ENHANCED**: Added best practice to run `./node_modules/.bin/eslint --max-warnings 0 .` locally to match CI behavior

Copilot AI Feb 21, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This WORK IN PROGRESS entry doesn’t follow the documented changelog format (it’s missing a “(Fixes #XX)” reference), and it suggests running the eslint binary directly even though the template guidance now says to use npm run lint to match CI. Consider updating this line to match the template wording and include the issue reference.

Suggested change
- (copilot) **ENHANCED**: Added best practice to run `./node_modules/.bin/eslint --max-warnings 0 .` locally to match CI behavior
- (copilot) **ENHANCED**: Added best practice to run `npm run lint` locally to match CI behavior (Fixes #95)

Copilot uses AI. Check for mistakes.
Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com>
Copilot AI requested a review from DutchmanNL February 21, 2026 22:58
@DutchmanNL
DutchmanNL merged commit b961f2c into main Feb 25, 2026
@DutchmanNL
DutchmanNL deleted the copilot/adopt-eslint-instructions branch February 25, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adopt ESLint instructions

3 participants