Add ESLint configuration guidance and lint-first CI/CD workflow - #79
Merged
Conversation
Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com>
Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement eslint checks and update version
Add ESLint configuration guidance and lint-first CI/CD workflow
Feb 16, 2026
DutchmanNL
approved these changes
Feb 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds comprehensive ESLint configuration guidance and establishes a lint-first validation workflow for CI/CD pipelines. It implements best practices from ioBroker.bambulab PR #244, where ESLint checks gate all other tests to fail fast on code quality issues. The version is incremented from 0.5.0 to 0.5.1 following semantic versioning.
Changes:
- Added ESLint Configuration and Best Practices section with official
@iobroker/eslint-configsetup, package.json scripts, common issues/fixes, and auto-fix guidance - Established lint-first CI/CD workflow pattern where all test jobs must depend on
check-and-lintjob completion - Updated README.md with new Code Quality & Linting section highlighting the ESLint guidance and workflow dependencies
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| template.md | Added comprehensive ESLint configuration section (lines 685-736) and lint-first validation workflow guidance (lines 778-809) with concrete YAML examples |
| README.md | Added Code Quality & Linting section describing ESLint features and updated version reference to 0.5.1 |
| package.json | Incremented version from 0.5.0 to 0.5.1 |
| config/metadata.json | Updated both main version and template version to 0.5.1 (consistent with multi-component versioning system) |
| .github/copilot-instructions.md | Updated version reference to 0.5.1 |
| CHANGELOG.md | Added four detailed entries documenting ESLint additions and enhancements under WORK IN PROGRESS section |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts lint-first validation workflow from ioBroker.bambulab PR #244, where ESLint checks gate all other tests to fail fast on code quality issues.
Changes
ESLint Configuration Section (template.md)
@iobroker/eslint-configsetup and configuration patternslint,lint:fix)CI/CD Workflow Enhancement (template.md)
check-and-lintcompletionDocumentation
Prevents wasting CI resources on tests that would fail due to linting errors. Provides faster feedback loop for developers.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/DrozmotiX/ioBroker.bambulab/pulls/244/usr/bin/curl curl -s REDACTED(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.