Skip to content

Add ESLint configuration guidance and lint-first CI/CD workflow - #79

Merged
DutchmanNL merged 4 commits into
mainfrom
copilot/implement-eslint-checks
Feb 16, 2026
Merged

Add ESLint configuration guidance and lint-first CI/CD workflow#79
DutchmanNL merged 4 commits into
mainfrom
copilot/implement-eslint-checks

Conversation

Copilot AI commented Feb 16, 2026

Copy link
Copy Markdown
Contributor

Adopts lint-first validation workflow from ioBroker.bambulab PR #244, where ESLint checks gate all other tests to fail fast on code quality issues.

Changes

ESLint Configuration Section (template.md)

  • Official @iobroker/eslint-config setup and configuration patterns
  • Package.json scripts (lint, lint:fix)
  • Common issues and auto-fix guidance

CI/CD Workflow Enhancement (template.md)

  • Explicit lint-first job dependency structure
  • All test jobs must depend on check-and-lint completion
jobs:
  check-and-lint:
    # Uses: ioBroker/testing-action-check@v1
    
  adapter-tests:
    needs: [check-and-lint]  # Blocks on lint failures
    
  integration-tests:
    needs: [check-and-lint, adapter-tests]

Documentation

  • README.md: Code Quality & Linting section
  • Version: 0.5.0 → 0.5.1

Prevents wasting CI resources on tests that would fail due to linting errors. Provides faster feedback loop for developers.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/DrozmotiX/ioBroker.bambulab/pulls/244
    • Triggering command: /usr/bin/curl curl -s REDACTED (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>Implement eslint checks</issue_title>
<issue_description>Adopt changes in copilot instruction as in https://github.com/DrozmotiX/ioBroker.bambulab/actions/runs/22077999711/job/63797265592?pr=244, update readme and numb version </issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits February 16, 2026 21:40
Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com>
Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com>
Copilot AI changed the title [WIP] Implement eslint checks and update version Add ESLint configuration guidance and lint-first CI/CD workflow Feb 16, 2026
Copilot AI requested a review from DutchmanNL February 16, 2026 21:43
@DutchmanNL
DutchmanNL marked this pull request as ready for review February 16, 2026 22:00
Copilot AI review requested due to automatic review settings February 16, 2026 22:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds comprehensive ESLint configuration guidance and establishes a lint-first validation workflow for CI/CD pipelines. It implements best practices from ioBroker.bambulab PR #244, where ESLint checks gate all other tests to fail fast on code quality issues. The version is incremented from 0.5.0 to 0.5.1 following semantic versioning.

Changes:

  • Added ESLint Configuration and Best Practices section with official @iobroker/eslint-config setup, package.json scripts, common issues/fixes, and auto-fix guidance
  • Established lint-first CI/CD workflow pattern where all test jobs must depend on check-and-lint job completion
  • Updated README.md with new Code Quality & Linting section highlighting the ESLint guidance and workflow dependencies

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
template.md Added comprehensive ESLint configuration section (lines 685-736) and lint-first validation workflow guidance (lines 778-809) with concrete YAML examples
README.md Added Code Quality & Linting section describing ESLint features and updated version reference to 0.5.1
package.json Incremented version from 0.5.0 to 0.5.1
config/metadata.json Updated both main version and template version to 0.5.1 (consistent with multi-component versioning system)
.github/copilot-instructions.md Updated version reference to 0.5.1
CHANGELOG.md Added four detailed entries documenting ESLint additions and enhancements under WORK IN PROGRESS section

Comment thread CHANGELOG.md Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@DutchmanNL
DutchmanNL merged commit aee9195 into main Feb 16, 2026
2 checks passed
@DutchmanNL
DutchmanNL deleted the copilot/implement-eslint-checks branch February 16, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement eslint checks

3 participants