Fix excessive duplicate issue creation in version check workflows - #74
Conversation
…ing old issues Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com>
Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com>
Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com>
|
@copilot you forgot to make an update into the changelog, please review this PR based on latest commits made to master branch and update where necessary. |
…Instructions into copilot/fix-excessive-issue-creation
Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com>
CHANGELOG.md has been updated with three entries documenting the duplicate issue prevention fix:
Also merged the latest changes from main branch (PR #72). All tests pass. Commit: 7136f78 |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the excessive duplicate issue creation bug in version check workflows by implementing proper issue detection and cleanup logic. The workflows now filter by creator (github-actions[bot]), close ALL existing issues before creating new ones, and rely on title pattern matching instead of labels.
Key Changes
- Modified 4 workflow files to prevent duplicate issues using consistent detection logic
- Added comprehensive test suite (40 tests) to validate duplicate prevention across all workflows
- Updated documentation in templates/README.md and TESTING.md to explain the new behavior
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| templates/centralized-version-check-action.yml | Updated issue detection to filter by creator and title pattern, close all existing issues with proper conditions |
| templates/weekly-version-check-action.yml | Updated issue detection to filter by creator and title pattern, close all existing issues with proper conditions |
| templates/ghAction-AutomatedVersionCheckAndUpdate.yml | Updated issue detection logic but missing critical if condition on issue-check step |
| snippets/github-action-version-check.yml | Updated issue detection to filter by creator and title pattern, close all existing issues with proper conditions |
| tests/test-issue-duplicate-prevention.sh | Added 40 comprehensive tests but missing validation for step-level if conditions |
| templates/README.md | Added documentation explaining duplicate issue prevention mechanism |
| TESTING.md | Added comprehensive documentation of issue duplicate prevention testing |
| CHANGELOG.md | Added detailed changelog entries following AlCalzone release-script standard |
* Document CI/CD pipeline in template.md Added CI/CD pipeline details for testing and release process. * Update template.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Adopt PR #76 changes: Consolidate CI/CD documentation and bump to v0.5.0 (#77) * Initial plan * Apply PR #76: Consolidate CI/CD documentation and bump to v0.5.0 Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix workflow example to use ubuntu-22.04 for consistency Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com> Co-authored-by: Rafal Drozda <DutchmanNL@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@copilot rebase pr in line with latest changes on main branch and resolve merge conflicts |
…ing old issues Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com>
Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com>
Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com>
Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Rebase completed successfully. The branch has been rebased on the latest main branch (including PR #75 for CI/CD documentation and PR #72 for @copilot assignment removal). CHANGELOG.md merge conflicts have been resolved - the duplicate issue prevention entries are now in the WORK IN PROGRESS section, with version 0.5.0 properly placed below. All 40 tests for duplicate prevention pass. The local branch is ready but needs a force push to update the remote due to the rebase changing history. I don't have direct access to force push - you may need to manually run Commits after rebase:
Rebase completed successfully and pushed to the remote branch. The PR is now up to date with the latest main branch. ✅ Rebased on main (includes PR #75 - CI/CD documentation and PR #72 - @copilot assignment removal) The CHANGELOG now has the correct structure with duplicate issue prevention entries in WORK IN PROGRESS section and version 0.5.0 properly placed below. Commit: 019dc3c |
…tion' into copilot/fix-excessive-issue-creation after rebase
✅ Complete - Fix for Excessive Update Issues Created
Problem Solved
The workflow was creating multiple duplicate issues for template updates because:
Solution Implemented
Fixed 4 workflow files with consistent duplicate prevention logic:
Issue detection now checks:
github-actions[bot]ONLY (not all users)Closes ALL existing issues:
forloopAlways creates new issue:
Testing & Documentation
test-issue-duplicate-prevention.shtemplates/README.mdandTESTING.mdRequirements Met
✅ Workflow must not create two identical issues
✅ Workflow must close ALL older issues if one or more exists
✅ Workflow must not rely on labels
✅ Workflow checks creator and title only
✅ CHANGELOG.md updated with detailed entries
✅ Rebased on main with all conflicts resolved
✅ Branch ready for merge
Original prompt
Fixes #64
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.