Skip to content

Fix excessive duplicate issue creation in version check workflows - #74

Merged
DutchmanNL merged 17 commits into
mainfrom
copilot/fix-excessive-issue-creation
Feb 16, 2026
Merged

Fix excessive duplicate issue creation in version check workflows#74
DutchmanNL merged 17 commits into
mainfrom
copilot/fix-excessive-issue-creation

Conversation

Copilot AI commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

✅ Complete - Fix for Excessive Update Issues Created

Problem Solved

The workflow was creating multiple duplicate issues for template updates because:

  1. Issue detection relied on labels which could be missing or modified
  2. Only the first matching issue was checked (not all)
  3. Old issues were never closed, just used as a "skip creation" flag

Solution Implemented

  • Fixed 4 workflow files with consistent duplicate prevention logic:

    • templates/centralized-version-check-action.yml
    • templates/weekly-version-check-action.yml
    • templates/ghAction-AutomatedVersionCheckAndUpdate.yml
    • snippets/github-action-version-check.yml
  • Issue detection now checks:

    • Creator: github-actions[bot] ONLY (not all users)
    • Title pattern: copilot + (template|setup|update|instructions)
    • NO dependency on labels
  • Closes ALL existing issues:

    • Iterates through all matches with for loop
    • Adds explanatory comment before closing
    • Logs count of closed issues
  • Always creates new issue:

    • Removed conditional check that could skip creation
    • Ensures users always have current update information

Testing & Documentation

Requirements Met

✅ Workflow must not create two identical issues
✅ Workflow must close ALL older issues if one or more exists
✅ Workflow must not rely on labels
✅ Workflow checks creator and title only
✅ CHANGELOG.md updated with detailed entries
✅ Rebased on main with all conflicts resolved
✅ Branch ready for merge

Original prompt

This section details on the original issue you should resolve

<issue_title>[BUG] Excessive update Issues created</issue_title>
<issue_description>### Prerequisites

  • I have searched existing issues to ensure this is not a duplicate
  • I have followed the setup guide and troubleshooting steps
  • This issue is related to the ioBroker Copilot Instructions template or setup process

Issue Type

Bug - Unexpected behavior or error

Severity

High - Significant impact on adapter development

Current Behavior

Workflow creates multiple issues.

Image

Expected Behavior

Workflow msut not create two identical issues.
Workflow must close ALL older issues if one or more exists.
Workflow must not rely on labels but check creator and title only.

Steps to Reproduce

rerun wiorkflows

GitHub Copilot Status

Unknown - Not sure if it's working

Template Version

unknown

Operating System

Other (please specify in additional context)

Node.js Version

n/a

Error Messages/Logs


Configuration Details

No response

Additional Context

No response

Workaround

  • I have found a temporary workaround (please describe in additional context)
  • I have not found any workaround
  • I need help finding a workaround</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #64


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Copilot AI and others added 3 commits October 15, 2025 21:06
…ing old issues

Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com>
Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com>
Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix excessive update issues created by workflow Fix excessive duplicate issue creation in version check workflows Oct 15, 2025
Copilot AI requested a review from DutchmanNL October 15, 2025 21:12
@DutchmanNL

Copy link
Copy Markdown
Contributor

@copilot you forgot to make an update into the changelog, please review this PR based on latest commits made to master branch and update where necessary.

Copilot AI and others added 2 commits November 19, 2025 20:54
Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com>

Copilot AI commented Nov 19, 2025

Copy link
Copy Markdown
Contributor Author

@copilot you forgot to make an update into the changelog, please review this PR based on latest commits made to master branch and update where necessary.

CHANGELOG.md has been updated with three entries documenting the duplicate issue prevention fix:

  • Main fix entry explaining the creator filtering, issue closing, and title pattern matching changes
  • Testing entry for the 40 new tests added
  • Documentation enhancement entry for the updated README and TESTING files

Also merged the latest changes from main branch (PR #72). All tests pass.

Commit: 7136f78

@DutchmanNL
DutchmanNL marked this pull request as ready for review November 19, 2025 20:59
Copilot AI review requested due to automatic review settings November 19, 2025 20:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the excessive duplicate issue creation bug in version check workflows by implementing proper issue detection and cleanup logic. The workflows now filter by creator (github-actions[bot]), close ALL existing issues before creating new ones, and rely on title pattern matching instead of labels.

Key Changes

  • Modified 4 workflow files to prevent duplicate issues using consistent detection logic
  • Added comprehensive test suite (40 tests) to validate duplicate prevention across all workflows
  • Updated documentation in templates/README.md and TESTING.md to explain the new behavior

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
templates/centralized-version-check-action.yml Updated issue detection to filter by creator and title pattern, close all existing issues with proper conditions
templates/weekly-version-check-action.yml Updated issue detection to filter by creator and title pattern, close all existing issues with proper conditions
templates/ghAction-AutomatedVersionCheckAndUpdate.yml Updated issue detection logic but missing critical if condition on issue-check step
snippets/github-action-version-check.yml Updated issue detection to filter by creator and title pattern, close all existing issues with proper conditions
tests/test-issue-duplicate-prevention.sh Added 40 comprehensive tests but missing validation for step-level if conditions
templates/README.md Added documentation explaining duplicate issue prevention mechanism
TESTING.md Added comprehensive documentation of issue duplicate prevention testing
CHANGELOG.md Added detailed changelog entries following AlCalzone release-script standard

Comment thread templates/ghAction-AutomatedVersionCheckAndUpdate.yml Outdated
Comment thread templates/ghAction-AutomatedVersionCheckAndUpdate.yml Outdated
* Document CI/CD pipeline in template.md

Added CI/CD pipeline details for testing and release process.

* Update template.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Adopt PR #76 changes: Consolidate CI/CD documentation and bump to v0.5.0 (#77)

* Initial plan

* Apply PR #76: Consolidate CI/CD documentation and bump to v0.5.0

Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com>

* Update CHANGELOG.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Fix workflow example to use ubuntu-22.04 for consistency

Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com>
Co-authored-by: Rafal Drozda <DutchmanNL@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com>
DutchmanNL and others added 2 commits February 16, 2026 20:48
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@DutchmanNL

DutchmanNL commented Feb 16, 2026

Copy link
Copy Markdown
Contributor

@copilot rebase pr in line with latest changes on main branch and resolve merge conflicts

Copilot AI and others added 3 commits February 16, 2026 19:50
…ing old issues

Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com>
Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com>
Copilot AI and others added 4 commits February 16, 2026 19:50
Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com>
Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI commented Feb 16, 2026

Copy link
Copy Markdown
Contributor Author

@copilot rebase pr in line with latest changes on main branch and resolve merge conflicts

Rebase completed successfully. The branch has been rebased on the latest main branch (including PR #75 for CI/CD documentation and PR #72 for @copilot assignment removal).

CHANGELOG.md merge conflicts have been resolved - the duplicate issue prevention entries are now in the WORK IN PROGRESS section, with version 0.5.0 properly placed below.

All 40 tests for duplicate prevention pass. The local branch is ready but needs a force push to update the remote due to the rebase changing history. I don't have direct access to force push - you may need to manually run git push --force or approve the force push through another method.

Commits after rebase:

  • 91945c8: Update templates/ghAction-AutomatedVersionCheckAndUpdate.yml
  • 066e003: Update templates/ghAction-AutomatedVersionCheckAndUpdate.yml
  • 15431b4: Add CHANGELOG entries for duplicate issue prevention fix

@copilot rebase pr in line with latest changes on main branch and resolve merge conflicts

Rebase completed successfully and pushed to the remote branch. The PR is now up to date with the latest main branch.

✅ Rebased on main (includes PR #75 - CI/CD documentation and PR #72 - @copilot assignment removal)
✅ All CHANGELOG.md merge conflicts resolved
✅ All 40 duplicate prevention tests pass
✅ Branch synchronized with remote

The CHANGELOG now has the correct structure with duplicate issue prevention entries in WORK IN PROGRESS section and version 0.5.0 properly placed below.

Commit: 019dc3c

…tion' into copilot/fix-excessive-issue-creation after rebase
Copilot AI requested a review from DutchmanNL February 16, 2026 19:55
@DutchmanNL
DutchmanNL merged commit 0842509 into main Feb 16, 2026
2 checks passed
@DutchmanNL
DutchmanNL deleted the copilot/fix-excessive-issue-creation branch February 16, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Excessive update Issues created

3 participants