Skip to content

[BUG] incorrect suggusteion to add non standard scripts #99

Description

@mcm1957

Prerequisites

  • I have searched existing issues to ensure this is not a duplicate
  • I have followed the setup guide and troubleshooting steps
  • This issue is related to the ioBroker Copilot Instructions template or setup process

Issue Type

Template Issue - Problem with template content or structure

Severity

Medium - Affects functionality but not critical

Current Behavior

The template contains a suggestion to add:

{
"scripts": {
"translate": "translate-adapter",
"validate:translations": "node scripts/validate-translations.js",
"pretest": "npm run lint && npm run validate:translations"
}
}

The file scripts/validate-translations.js is a non standard script and not available at normal installations. So the npm script validate_translations must be removed.

Adding this script is not a appropiate action as such tests / validations shoul dnever be done by local scripts unless technicalls required. If such a test seems to be useful please add to iobroker.dev or raise a feature issue there

npm script pretest does not make sense as npm run pretest requires more typing then npm run lint ... So please remove from template.

Template should be as small as possible. It is NOT a gioid idea to instruct copilot to add additional commans / scripts etc. as all this information must be parsed by every run of copilot. Copilot instructions should not try to do things which can be done by create-adapter or reported repository-checker too. Public Copolit instructions must be limited to general rules like adding changes to README, not to add version infos into (io-)package.json, etc. which are relevant for every run.

Expected Behavior

Coüpilot instructions do not refer to content of package.json

Steps to Reproduce

n/a

GitHub Copilot Status

Yes - Copilot is active and working

Template Version

0.5.7

Operating System

Windows

Node.js Version

No response

Error Messages/Logs


Configuration Details

No response

Additional Context

Currently I am revising the content of central file. It looks to have too much content. I will replacing it by a provate version if Copilot tries to change existing setup unrelated to the changes requested or needed by the assigned issue.

Workaround

  • I have found a temporary workaround (please describe in additional context)
  • I have not found any workaround
  • I need help finding a workaround

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions