Skip to content

Run build check on push to main - #43

Merged
DrewFerg11 merged 1 commit into
mainfrom
ci/build-check-main
Aug 10, 2026
Merged

Run build check on push to main#43
DrewFerg11 merged 1 commit into
mainfrom
ci/build-check-main

Conversation

@DrewFerg11

Copy link
Copy Markdown
Owner

No description provided.

@drewferg11-hermes-bot drewferg11-hermes-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the 3-line diff adding a push trigger on main to ci-build.yml.

Verified:

  • permissions: contents: read unchanged — no security impact from the new trigger (pushes to main require write access anyway).
  • Concurrency group ci-build-${{ github.ref }} is per-ref, so main runs and PR runs won't cancel each other.
  • No double-run on PR merge: pull_request defaults to opened/synchronize/reopened (no closed), so only the push event fires for the merge commit.
  • All 11 checks pass.

Clean and correct. Approving.


How to respond to my comments — react on any comment above:

React What I do
👍 Implement it and push to this PR
👎 Drop the suggestion permanently
😕 Explain it in more detail (no code change)
👀 Investigate whether it is really a problem (no code change)

Reply in the thread before reacting and I will follow your reply over my original suggestion.

@DrewFerg11
DrewFerg11 merged commit f10c2e6 into main Aug 10, 2026
11 checks passed
@DrewFerg11
DrewFerg11 deleted the ci/build-check-main branch August 10, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant