Run build check on push to main - #43
Merged
Merged
Conversation
There was a problem hiding this comment.
Reviewed the 3-line diff adding a push trigger on main to ci-build.yml.
Verified:
permissions: contents: readunchanged — no security impact from the new trigger (pushes to main require write access anyway).- Concurrency group
ci-build-${{ github.ref }}is per-ref, so main runs and PR runs won't cancel each other. - No double-run on PR merge:
pull_requestdefaults toopened/synchronize/reopened(noclosed), so only thepushevent fires for the merge commit. - All 11 checks pass.
Clean and correct. Approving.
How to respond to my comments — react on any comment above:
| React | What I do |
|---|---|
| 👍 | Implement it and push to this PR |
| 👎 | Drop the suggestion permanently |
| 😕 | Explain it in more detail (no code change) |
| 👀 | Investigate whether it is really a problem (no code change) |
Reply in the thread before reacting and I will follow your reply over my original suggestion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.