Skip to content

Fix MacOS cross compilation - #9

Merged
DoumanAsh merged 1 commit into
DoumanAsh:masterfrom
jaspwr:apple-cross-compilation-fix
Aug 12, 2025
Merged

Fix MacOS cross compilation#9
DoumanAsh merged 1 commit into
DoumanAsh:masterfrom
jaspwr:apple-cross-compilation-fix

Conversation

@jaspwr

@jaspwr jaspwr commented Aug 12, 2025

Copy link
Copy Markdown
Contributor

The host flag is also required when cross compiling for other architectures for MacOS. Checking if the target includes "apple" also covers IOS.

@jaspwr

jaspwr commented Aug 12, 2025

Copy link
Copy Markdown
Contributor Author

Also as a side note I think the LGPL only requires the vendored copy of LAME to be licensed under LGPL the whole crate can be whatever. That what the "lesser" part means.

However, a larger work using the licensed work through interfaces provided by the licensed work may be distributed under different terms and without source code for the larger work.

https://choosealicense.com/licenses/lgpl-3.0/

Correct me if I'm wrong.

@DoumanAsh

Copy link
Copy Markdown
Owner

Ah, that was rather lame mistake
Thanks for correcting it

Also as a side note I think the LGPL only requires the vendored copy of LAME to be licensed under LGPL the whole crate can be whatever. That what the "lesser" part means.

I include lame source code for static build, so I use the same license (there is not much benefit in having separate license anyway when you depend on lame's source code)

@DoumanAsh
DoumanAsh merged commit 7885e99 into DoumanAsh:master Aug 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants