Conversation
This reverts commit 3674344.
Code Buddy - Setup
Extra functionalities
Code Buddy - API documentation
There was a problem hiding this comment.
Very good job so far!
There are only some very small issues that you still need to work on to prepare your project for the final evaluation but you are almost there!
Suggested changes
Check the comments under the review.
You can use as many of my suggestions as you want. If there is anything you would like to skip - feel free to do that. However, I strongly recommend you to take them into account as they can make your code better.
Highlights
- Awesome README file and PR description.
- Your code is clean and well organized.
- Good job making tests, even tho it's not mentioned in the requirements, I would have asked for them anyway.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
|
|
||
| api :GET, '/meeting_types', 'Gets the show page for a meeting type' | ||
| def show | ||
| meeting_type = MeetingType.find(params[:id]) |
There was a problem hiding this comment.
- I suggest that you use an instance variable for
@meeting_typeand set it in a private function called in abefore_action, this way you can avoid doing this everywhere you need to. This is also a valid suggestion for the other controllers.
| resources :user_details | ||
| resources :reservations |
There was a problem hiding this comment.
- Since this creates all available routes, I would advise you to specify which ones you are really using, so that they aren't created needlessly.
We opened this PR for you to review our project if it is as requested 👁️
Here we created a Rails API app as we used it for our Code Buddy App backend. 💯 💯
Project requirements that are done:
Feel free to review 👀 our project and if you have any questions please ask us! 💪
Frontend pull