Skip to content

Final capstone project - Code Buddy Backend - #20

Open
Donard97 wants to merge 87 commits into
mainfrom
develop
Open

Final capstone project - Code Buddy Backend#20
Donard97 wants to merge 87 commits into
mainfrom
develop

Conversation

@Donard97

@Donard97 Donard97 commented Feb 5, 2022

Copy link
Copy Markdown
Owner

We opened this PR for you to review our project if it is as requested 👁️

Here we created a Rails API app as we used it for our Code Buddy App backend. 💯 💯

Project requirements that are done:

  • Setup of the project ☑️
  • Create ER Diagram ☑️
  • Create Models and Migrations ☑️
  • Create Controllers and API Endpoints ☑️
  • Create Validations ☑️
  • Create Error Handlers in Controllers ☑️
  • Writes tests ☑️
  • Add API documentation ☑️
  • Deploy the app backend ☑️

Feel free to review 👀 our project and if you have any questions please ask us! 💪

Frontend pull

@MuriloRoque MuriloRoque left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Donard97, @ahzia,

Very good job so far!
There are only some very small issues that you still need to work on to prepare your project for the final evaluation but you are almost there!

Suggested changes

Check the comments under the review.

You can use as many of my suggestions as you want. If there is anything you would like to skip - feel free to do that. However, I strongly recommend you to take them into account as they can make your code better.

Highlights

  • Awesome README file and PR description.
  • Your code is clean and well organized.
  • Good job making tests, even tho it's not mentioned in the requirements, I would have asked for them anyway.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


api :GET, '/meeting_types', 'Gets the show page for a meeting type'
def show
meeting_type = MeetingType.find(params[:id])

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I suggest that you use an instance variable for @meeting_type and set it in a private function called in a before_action, this way you can avoid doing this everywhere you need to. This is also a valid suggestion for the other controllers.

Comment thread config/routes.rb
Comment on lines +10 to +11
resources :user_details
resources :reservations

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Since this creates all available routes, I would advise you to specify which ones you are really using, so that they aren't created needlessly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants