fix: redact registry password from build failure logs and emails - #5068
Open
Souvik-Cyclic wants to merge 1 commit into
Open
fix: redact registry password from build failure logs and emails#5068Souvik-Cyclic wants to merge 1 commit into
Souvik-Cyclic wants to merge 1 commit into
Conversation
dosubot
Bot
added
the
size:M
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Souvik-Cyclic
force-pushed
the
fix/redact-registry-password-logs-4693
branch
from
August 12, 2026 19:31
603b1d1 to
3ef7f46
Compare
Souvik-Cyclic
force-pushed
the
fix/redact-registry-password-logs-4693
branch
2 times, most recently
from
August 12, 2026 19:37
0a990d4 to
2efb669
Compare
The docker login command embeds the registry password, so when a deployment fails the command shows up in the error message that gets written to the deployment logs, sent in build-failure emails, and carried by the rethrown error into upstream log/queue handlers, leaking the password in plain text. Scrub the application's registry, build and rollback passwords from the error before it is logged, emailed, or rethrown, across the deploy, rebuild and preview paths. Fixes Dokploy#4693
Souvik-Cyclic
force-pushed
the
fix/redact-registry-password-logs-4693
branch
from
August 12, 2026 19:43
2efb669 to
81afaf4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
The docker login command built for deployments embeds the registry password (
printf %s '<password>' | docker login … --password-stdin). When a deploy fails, that command lands in the error message, which is written to the deployment logs and sent in build-failure emails, leaking the password in plain text (#4693).This adds
redactSecrets/redactRegistryPasswordsin the registry service and scrubs the application's registry, build and rollback passwords from the error before it is logged or emailed, across the deploy/rebuild/preview paths.Checklist
canarybranch.Issues related (if applicable)
closes #4693
Screenshots (if applicable)
N/A - covered by a unit test for the redaction helper (
apps/dokploy/__test__/registry/redact-secrets.test.ts).Greptile Summary
The PR prevents application deployment failures from exposing registry passwords through deployment logs, build-failure notifications, or propagated execution errors.
ExecErrorinstances with sanitized fields and removes the nested original error.Confidence Score: 5/5
The PR appears safe to merge.
The previously reported raw rethrow, nested execution-error, and shell-escaped password disclosure paths are addressed, and no blocking failure remains.
Reviews (4): Last reviewed commit: "fix: redact registry password from build..." | Re-trigger Greptile
Context used: