fix(monitoring): default cleanup cron - #5026
Open
soumajitgh wants to merge 3 commits into
Open
Conversation
Backfill blank schedules and fall back safely so remote monitoring cannot crash-loop on setup.\n\nCloses Dokploy#4950
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0 0 * * *METRICS_CONFIGvalueRoot cause
Remote server setup preserved the schema's empty
cronJobdefault. The monitoring container passed that value to the cron parser, exited on the resulting error, and then crash-looped under itsalwaysrestart policy.Validation
go test ./...(fromapps/monitoring)pnpm -C apps/dokploy run typecheckpnpm exec biome check packages/server/src/db/schema/server.ts packages/server/src/setup/server-setup.tsgit diff --checkCloses #4950
Greptile Summary
The PR defaults blank remote-monitoring cleanup schedules to a daily midnight cron while preserving valid configured schedules and removing token-bearing configuration logs.
METRICS_CONFIGenvironment value.Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains.
Reviews (2): Last reviewed commit: "chore: remove superseded monitoring migr..." | Re-trigger Greptile
Context used: