Skip to content

fix(ci): add scope to setup-node for npm registry publishing - #23

Merged
frankieyan merged 1 commit into
mainfrom
frankieyan/npm-publish-token
Jan 18, 2026
Merged

frankieyan merged 1 commit into
mainfrom
frankieyan/npm-publish-token

Conversation

@frankieyan

Copy link
Copy Markdown
Member

Follow up fix on: #19

The second setup-node action was missing the scope parameter, causing npm publish to use the GitHub Packages registry config from the first setup-node instead of the npmjs.org registry.

image

The second setup-node action was missing the scope parameter, causing
npm publish to use the GitHub Packages registry config from the first
setup-node instead of the npmjs.org registry.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@frankieyan
frankieyan requested a review from a team as a code owner January 18, 2026 02:47
@frankieyan
frankieyan requested review from rmartins90 and removed request for a team January 18, 2026 02:47
@frankieyan frankieyan added the 👀 Show PR requests review before or after merging. Can be merged once checks pass. label Jan 18, 2026

@doistbot-app doistbot-app Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change correctly limits the registry configuration to the @doist scope, ensuring the correct registry is used during the publish step as described.

@frankieyan
frankieyan merged commit 8352f69 into main Jan 18, 2026
2 checks passed
@frankieyan
frankieyan deleted the frankieyan/npm-publish-token branch January 18, 2026 02:50
@rmartins90

Copy link
Copy Markdown

✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👀 Show PR requests review before or after merging. Can be merged once checks pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants