Skip to content

fix(search): accept --offset, which the more-results hint suggests - #148

Merged
craigcarlyle merged 2 commits into
mainfrom
craigcarlyle/search-offset
Oct 14, 2026
Merged

craigcarlyle merged 2 commits into
mainfrom
craigcarlyle/search-offset

Conversation

@craigcarlyle

Copy link
Copy Markdown
Contributor

ol search ends with a hint to use --offset for more results, but didn't accept the option, so following the hint failed with unknown option '--offset'. It takes --offset now, the same way document list does, and the README and the skill list it.

Also fixed: with --json, the same hint went to stdout after the JSON, so ol search --json | jq broke whenever there was another page. In JSON mode it goes to stderr now. Human output is unchanged.

Tested: npm test (233 passing, with new tests for both), type-check, lint, format and the skill sync check. Against the handbook, ol search "Todoist" --limit 3 --offset 3 returns the next three documents, and the --json output parses.

🤖 Generated with Claude Code

craigcarlyle and others added 2 commits October 13, 2026 15:13
ol search pointed at --offset for the next page of results, then rejected
the option. It takes it now, the same way document list does.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
With --json the hint was printed to stdout after the JSON, so
`ol search --json | jq` failed whenever there was another page. In JSON
mode it goes to stderr now.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@craigcarlyle craigcarlyle added the 🙋 Ask PR requires review and approval before merging. Merge after checks pass. label Oct 13, 2026

@doistbot doistbot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR updates fix(search): accept --offset, which the more-results hint suggests. No issues were flagged in the reviewed diff.

Share Feedback • Review Logs

@henningmu henningmu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you 🙌

@craigcarlyle craigcarlyle self-assigned this Oct 14, 2026
@craigcarlyle
craigcarlyle merged commit 0b3dc79 into main Oct 14, 2026
5 checks passed
@craigcarlyle
craigcarlyle deleted the craigcarlyle/search-offset branch October 14, 2026 14:54
doist-release-bot Bot added a commit that referenced this pull request Oct 14, 2026
## [2.1.9](v2.1.8...v2.1.9) (2026-10-14)

### Bug Fixes

* **search:** accept --offset, which the more-results hint suggests ([#148](#148)) ([0b3dc79](0b3dc79))
@doist-release-bot

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 2.1.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🙋 Ask PR requires review and approval before merging. Merge after checks pass. released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants