Enhance notifications to avoid duplicates during auto search cycles#780
Conversation
There was a problem hiding this comment.
Code Review
This pull request implements notification deduplication (transition gating) in the auto-search cron job, ensuring that availability and update notifications are only triggered on a false-to-true transition rather than on every cycle. It also updates the frontend settings description and adds comprehensive test coverage. Feedback points out a potential issue where the shared searchResultsAvailable flag is not reset when a game transitions from wanted to owned, which could cause users to miss the first update notification.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cb2fb739d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The flag is reused for two meanings (main release available for wanted games, update available for owned games) and was never reset on the wanted -> owned/downloading transition, silently suppressing the first genuine "Game Updates Available" notification. Resolves gemini-code-assist and chatgpt-codex-connector review comments on PR #780.
cb2fb73 to
e556dcd
Compare
|



This pull request improves notification logic for game availability and updates, ensuring users are only notified when new results become available (i.e., on a false→true transition), rather than on every search cycle. It also updates the UI to clarify notification behavior when preferred release groups are enabled, and adds comprehensive tests to verify deduplication and gating logic.
Notification deduplication and transition gating:
server/cron.ts). [1] [2] [3] [4] [5]Preferred release groups notification logic:
client/src/components/PreferredReleaseGroupsSettings.tsx).Testing and verification:
server/__tests__/cron_autosearch.test.ts).