Design polish label homepage - #5
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 611a8aa84d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .section-links { | ||
| grid-column: 1; | ||
| grid-row: auto; | ||
| justify-self: stretch; | ||
| width: 100%; |
There was a problem hiding this comment.
At viewports up to 56rem, this responsive declaration is overridden by the later .section-links rules at lines 1560–1613. At 760px and below, .section-heading becomes a one-column grid, but the wrapper consequently retains grid-column: 2, creating an implicit second column that compresses the release heading and can cause horizontal overflow. Place this override after the base rules or include .section-links in the later responsive selector.
Useful? React with 👍 / 👎.
| .release-row[aria-pressed="true"] .release-info strong::after { | ||
| color: var(--red); | ||
| content: " / PLAYING"; |
There was a problem hiding this comment.
The aria-pressed state represents the selected currentTrack, not playback: registerTracks automatically selects the first catalog entry on mount, and the state remains true when playback is paused or when a release has no preview. Consequently the page initially labels the first, unavailable preview as / PLAYING, and paused or unavailable selections receive the same incorrect status even while the player reports otherwise. Drive this marker from isPlaying as well as the selected track.
Useful? React with 👍 / 👎.
1 participant
Summary
Checks
Note: Full npm test/build was attempted, but dependency install exceeded the sandbox timeout.