This repository was archived by the owner on May 21, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 17
feat: implemented user order details #360
Open
defudef
wants to merge
10
commits into
master
Choose a base branch
from
feature/197-user-order-details
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
594b270
implemented user order details
e23ee1c
Fixes according to the code review
ec56976
taxes as array + increased test coverage
b0278ba
changes according to CR
24ff35b
simplified string
d35dd84
added coma separator
fc0cd8d
simplified transformation
0a8032f
template changes. added onSSR
adad6dd
Removed order number. Added TODO
96ecb0a
Changes according to CR
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -207,11 +207,14 @@ export interface CheckoutGetters<SHIPPING_METHOD> { | |||||||||
| [getterName: string]: (element: any, options?: any) => unknown; | ||||||||||
| } | ||||||||||
|
|
||||||||||
| export interface UserOrderGetters<ORDER> { | ||||||||||
| export interface UserOrderGetters<ORDER, ORDER_ITEM> { | ||||||||||
| getDate: (order: ORDER) => string; | ||||||||||
| getId: (order: ORDER) => string; | ||||||||||
| getStatus: (order: ORDER) => string; | ||||||||||
| getPrice: (order: ORDER) => number; | ||||||||||
| getPrice: (order: ORDER) => AgnosticPrice; | ||||||||||
| getItems: (order: ORDER) => ORDER_ITEM[]; | ||||||||||
| getBillingAddress: (address: ORDER) => string; | ||||||||||
| getShippingAddress: (address: ORDER) => string; | ||||||||||
|
Comment on lines
+216
to
+217
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. would change that for implementation to decide about address structure
Suggested change
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove and create RFC, ideally before 4 m so we can discuss it on decision making window @defudef |
||||||||||
| [getterName: string]: (element: any, options?: any) => unknown; | ||||||||||
| } | ||||||||||
|
|
||||||||||
|
|
||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't that be a set of helpers OR just a non-agnostic object?
@andrzejewsky we've just discussed that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's temporary actually (just to keep DRY)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if something is temporarly add an issue and todo here with issue linked