Skip to content

Add Browser Redirect Link on Update Failures - #33

Merged
DisabledAbel merged 2 commits into
mainfrom
update-browser-redirect-on-error-14134903815668154225
Aug 10, 2026
Merged

Add Browser Redirect Link on Update Failures#33
DisabledAbel merged 2 commits into
mainfrom
update-browser-redirect-on-error-14134903815668154225

Conversation

@DisabledAbel

@DisabledAbel DisabledAbel commented Aug 10, 2026

Copy link
Copy Markdown
Owner

Provides an action button/link to manually open the update/release URL in a browser if the automated in-app download or signature validation fails (such as when upgrading between debug and release variants). Updates both the native AlertDialog error paths and the Jetpack Compose UpdateDialogScreen error UI.


PR created automatically by Jules for task 14134903815668154225 started by @DisabledAbel

Summary by CodeRabbit

  • Bug Fixes
    • Update error dialogs now provide an “Open in Browser” option when a release or APK link is available.
    • Improved handling of browser-launch failures without disrupting the update flow.
    • Preserved the existing “Update Now” action when no update link is available.

…nload failures

When an automatic update check or installation fails (e.g. due to signature certificate mismatch), display an option to open the update release page or APK link directly in the device's web browser, enabling manual downloading and installation.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@DisabledAbel, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 6 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c65f4dc0-fd1c-477b-8522-f9e9f84b1391

📥 Commits

Reviewing files that changed from the base of the PR and between 135864f and 84f5db9.

📒 Files selected for processing (1)
  • app/src/main/java/com/tunnelguard/app/update/UpdateDialogScreen.kt
📝 Walkthrough

Walkthrough

Update error handling now uses cached release or APK URLs to offer an “Open in Browser” action. If no URL exists, the existing “Update Now” behavior remains. Browser-launch failures are caught and logged or ignored.

Changes

Update error browser fallback

Layer / File(s) Summary
Browser fallback actions
app/src/main/java/com/tunnelguard/app/UpdateManager.kt, app/src/main/java/com/tunnelguard/app/update/UpdateDialogScreen.kt
Update error flows resolve cached release or APK URLs. They show an “Open in Browser” action when a nonblank URL exists and retain the existing update action otherwise. Browser-launch failures are handled safely.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding a browser link for update failures.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@app/src/main/java/com/tunnelguard/app/update/UpdateDialogScreen.kt`:
- Around line 84-86: Update the exception handler around
context.startActivity(intent) to log the caught exception and provide the user
with a brief failure message or invoke the established failure callback,
matching the behavior used by UpdateManager.showUpdateErrorDialog instead of
silently ignoring the failure.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9994975e-f36e-4e29-9492-f896a183a16b

📥 Commits

Reviewing files that changed from the base of the PR and between c61bbad and 135864f.

📒 Files selected for processing (2)
  • app/src/main/java/com/tunnelguard/app/UpdateManager.kt
  • app/src/main/java/com/tunnelguard/app/update/UpdateDialogScreen.kt

Comment thread app/src/main/java/com/tunnelguard/app/update/UpdateDialogScreen.kt
… UI feedback

In UpdateDialogScreen, catch and log exceptions during browser launch attempts, showing a Toast failure notification to the user instead of silently ignoring the issue. Also update UpdateManager to offer a fallback browser redirection when update download/verification checks fail.
@DisabledAbel
DisabledAbel merged commit 7516c40 into main Aug 10, 2026
3 checks passed
@DisabledAbel
DisabledAbel deleted the update-browser-redirect-on-error-14134903815668154225 branch August 10, 2026 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant