Add Browser Redirect Link on Update Failures - #33
Conversation
…nload failures When an automatic update check or installation fails (e.g. due to signature certificate mismatch), display an option to open the update release page or APK link directly in the device's web browser, enabling manual downloading and installation.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
Next review available in: 6 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdate error handling now uses cached release or APK URLs to offer an “Open in Browser” action. If no URL exists, the existing “Update Now” behavior remains. Browser-launch failures are caught and logged or ignored. ChangesUpdate error browser fallback
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/src/main/java/com/tunnelguard/app/update/UpdateDialogScreen.kt`:
- Around line 84-86: Update the exception handler around
context.startActivity(intent) to log the caught exception and provide the user
with a brief failure message or invoke the established failure callback,
matching the behavior used by UpdateManager.showUpdateErrorDialog instead of
silently ignoring the failure.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 9994975e-f36e-4e29-9492-f896a183a16b
📒 Files selected for processing (2)
app/src/main/java/com/tunnelguard/app/UpdateManager.ktapp/src/main/java/com/tunnelguard/app/update/UpdateDialogScreen.kt
… UI feedback In UpdateDialogScreen, catch and log exceptions during browser launch attempts, showing a Toast failure notification to the user instead of silently ignoring the issue. Also update UpdateManager to offer a fallback browser redirection when update download/verification checks fail.
Provides an action button/link to manually open the update/release URL in a browser if the automated in-app download or signature validation fails (such as when upgrading between debug and release variants). Updates both the native AlertDialog error paths and the Jetpack Compose UpdateDialogScreen error UI.
PR created automatically by Jules for task 14134903815668154225 started by @DisabledAbel
Summary by CodeRabbit