Autowindow&navigator - #600
Open
LyonJack wants to merge 7 commits into
Open
Conversation
… and floating windows, optimize content handling for floating windows Fixes 1. Fix activation logic of selected items in navigator window 2. Fix layout and foreground color of selectedElementDescription under VS2013 theme for NavigatorWindow 3. Fix floating window size calculation logic 4. Fix potential null reference exceptions when traversing parent visual elements Improvements 1. Refine overall content handling logic of floating layout window control 2. Add support for content elements implementing the `ILayoutContentElement` interface to improve compatibility with various content types 3. Adjust icon size of dock context menu
Revised the size calculation logic within LayoutFloatingWindowControl when AutoWindowSizeWhenOpened is enabled. The expected size retrieved via the Measure method is used instead of relying on actual rendered dimensions, to more accurately resolve the intrinsic content size.
… into autowindow&navigator
Collaborator
|
Whats the purpose of this PR? That diff is huge |
Contributor
Author
|
Hi Stefan,
I encountered a Sonar static analysis error S4790 when building the current AvalonDock source code.
The error points to line 574 in source/Components/AvalonDock/Controls/Shell/Standard/Utilities.cs, triggered by the MD5 hash creation code.
MD5 here is only used to generate cache filenames for layout persistence, without any cryptographic security scenarios.
I have two solutions for your reference:
Add #pragma warning disable S4790 suppression around the MD5 block to skip this security rule;
Replace MD5 with SHA256 to fully eliminate the error.
I can submit a PR to fix this issue if you agree with either approach.
Looking forward to your reply.
原始邮件
发件人：Stefan Kneidl ***@***.***>
发件时间：2026年7月3日 22:53
收件人：Dirkster99/AvalonDock ***@***.***>
抄送：刘晓青 ***@***.***>, Author ***@***.***>
主题：Re: [Dirkster99/AvalonDock] Autowindow&navigator (PR #600)
sharpSteff left a comment (Dirkster99/AvalonDock#600)
Whats the purpose of this PR? That diff is huge
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you authored the thread.
|
added 2 commits
July 7, 2026 16:40
- Fix extra spaces in Spanish translations within Resources.es.resx - Add missing entries to the Portuguese translation file Resources.pt.resx
SonarAnalyzer.CSharp 10.32 introduced rule S6444, which requires regular expression calls to pass a matchTimeout to prevent ReDoS attacks. The Regex.Replace call in ToggleDockingManager.cs does not provide a timeout, so it triggers the rule; combined with TreatWarningsAsErrors=true in Directory.Build.props, the build fails. The pattern "(\\B[A-Z])" is a fixed, simple regex applied to internal enum names (e.g. DockZone -> "Dock Zone"). The input is not user-controlled, so there is no ReDoS risk. Suppressing the rule locally with #pragma warning disable S6444 keeps the other rules enabled and does not affect behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.