fix: 🐛 fix chain_second_seq bug when sequence length gte 200 - #9
fix: 🐛 fix chain_second_seq bug when sequence length gte 200#9nothing2sayi wants to merge 3 commits into
Conversation
|
Could you explain what this pull request changes? |
Hi @reneleonhardt, Sorry for the delay! Here is a breakdown of what this PR includes: Bugfix & Refactor: Fixed an issue in chain_second_seq when the sequence length is greater than or equal to 200. Replaced raw tags with an Enum to improve type safety and readability. Features: Added an as_str method for Tag for easier string representation. Added the quick_ratio function for faster calculation of sequence similarity ratio. Let me know if you need any adjustments! |
|
I'm no maintainer, but I find your contribution valuable! For me personally, I don't understand why you left a commented block, and if possible the fix should be separated from the enum: fix, enum, feature commits. In addition, I don't understand why there are no unit tests for your new methods, bugfixes and features. Did you check coverage before and after? |
No description provided.