Refactor/group and role names - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the role and permission system to replace the "hub" scope with a more consistent "lms" (Learning Management System) scope across the codebase. It updates role, group, and permission naming conventions, and ensures all logic, APIs, and tests use the new "lms" terminology. This change improves clarity and aligns the naming with the intended application domain.
The most important changes are:
Core Role and Scope Refactoring:
Scope.HUBenum toScope.LMSand updated all references to use "lms" instead of "hub" [1] [2] [3] [4].Roleenum: replacedHUB_ADMINwithLMS_ADMIN, changed role names to use hyphens (e.g.,lms-admin,course-owner,teaching-assistant), and movedCOURSE_CREATORto the LMS scope.RoleAssignment, so all group names now start withlms.(e.g.,lms.lms-admin,lms.course.<course_id>.<role>,lms.course.<course_id>.term.<term_id>.<role>).API and Permission Updates:
ADD_LMS_ADMINinstead ofADD_HUB_ADMIN), and updated the role-permission mappings accordingly [1] [2] [3].Documentation:
README.mdto reflect the new group naming conventions.This refactor ensures a consistent and clear role/permission model throughout the codebase, making future maintenance and extension easier.