fix(hooks): preserve mode on invalid arguments - #677
Open
l2yujw wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unsupported
/ponytailmode arguments currently replace the active session mode with the configured default.For example, when the active mode is
ultraand the configured default islite:silently changes the session to
lite.This PR makes unsupported arguments a no-op and adds a regression test proving that the active mode is preserved.
Root cause
The command parser assigned
getDefaultMode()to every unsupported argument:The normal mode-write path then persisted that fallback as if the user had explicitly selected it.
Fix
Unsupported arguments now leave
modeunset.The existing downstream
if (mode)guard prevents output and state mutation, while valid modes and bare status queries keep their existing behavior.Verification