Move shutter logic to plan level for analyser type scans - #350
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #350 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 31 30 -1
Lines 869 884 +15
=========================================
+ Hits 869 884 +15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Relm-Arrowny
requested changes
Aug 5, 2026
Relm-Arrowny
left a comment
Relm-Arrowny
left a comment
Collaborator
There was a problem hiding this comment.
Two very small check before merge otherwise I just have some nits.
Relm-Arrowny
approved these changes
Aug 6, 2026
| step: Mapping[Movable, Any], | ||
| pos_cache: dict[Movable, Any], | ||
| *args, | ||
| if analyser in detectors: |
Collaborator
There was a problem hiding this comment.
this is fine, if this is what we want, I think bluesky can double stage and double read probably will do no harm, this will break the script if user make a mistake.
Collaborator
Author
|
Blocked by DiamondLightSource/dodal#2151 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #349
Changes:
Instructions to reviewer on how to test:
Checks for reviewer