Skip to content

Grating angle fix - #5

Merged
csbrasnett merged 9 commits into
mainfrom
grating-angle-fix
Aug 3, 2026
Merged

Grating angle fix#5
csbrasnett merged 9 commits into
mainfrom
grating-angle-fix

Conversation

@csbrasnett

Copy link
Copy Markdown
Collaborator

Remove general assumption that pattern is perfectly horizontal/vertical across the detector.

@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.81560% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.74%. Comparing base (81d1f63) to head (de378cd).

Files with missing lines Patch % Lines
src/gratingcalibration/detector_calibration.py 89.79% 10 Missing ⚠️
src/gratingcalibration/beam_center_optimiser.py 82.14% 5 Missing ⚠️
src/gratingcalibration/main.py 20.00% 4 Missing ⚠️
src/gratingcalibration/beamstop_fitter.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main       #5       +/-   ##
===========================================
+ Coverage   34.09%   63.74%   +29.64%     
===========================================
  Files           8        8               
  Lines         569      673      +104     
===========================================
+ Hits          194      429      +235     
+ Misses        375      244      -131     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@csbrasnett
csbrasnett merged commit 88b349f into main Aug 3, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant