Repository navigation
Consolidate CLIs under a single dls-plc-tools Typer entry point - #1
Merged
Merged
Conversation
Match the entry point to the package name with `gui` and `read` subcommands (so `uvx dls-plc-tools gui <ip>` works), per a colleague's suggestion. Replaces the separate `dls-read-plc` / `dls-read-plc-gui` scripts. - Add a Typer app in __main__.py; extract reusable cores run_gui() and read_plc() from the old argparse mains. Subcommands lazy-import their heavy deps (PySide6 / aphyt) so --version/--help stay fast. - Add typer to dependencies; collapse [project.scripts] to just dls-plc-tools. - Suppress a false-positive pyright error on QMetaObject.invokeMethod (PySide6 stubs type the slot name as bytes, but the runtime requires str). - Update README/CLAUDE.md to the new invocation. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match the entry point to the package name with
guiandreadsubcommands (souvx dls-plc-tools gui <ip>works), per a colleague's suggestion. Replaces the separatedls-read-plc/dls-read-plc-guiscripts.